childSelector in init is too broad, affecting all links inside the photoswipe-gallery and showing "broken" images

Tested my theory with a Paragraphs Layout + .photoswipe-gallery class and two image Paragraphs, one with PSWP link, on without. No problem.

So we need to debug the JS to figure out what's accidentally added to the gallery.

Sounds a bit like an AJAX context issue and multi-initialization. Like the once() doesn't work correctly. That would explain why there are four as admin. Each AJAX requests adds another one.

@Grevil could you check that via JS Debugging in the browser in the project @thomas.frobieter mentioned?

PS @thomas.frobieter that would also explain why it doesn't happen in your test. Try something like AJAX filtering and I think the same will happen. For admins the administration menu might cause this.

Yes, that was my suspicion too, I had already talked to Grevil about it.

@thomas.frobieter just found another case logged out on the GS frontpage. I don't think there's AJAX running, but we can simply check that by logging the context calls.

Let's increase the priority.

Found it! The reasons are additional (non PS-intended) links in photoswipe-galeries, that should not be photoswipe links, but are handled as such.

We're using class "photoswipe" on all links that should open a photoswipe layer but forgot to use it in the initialization. Due to how PS5 works.

Without this fix

• All inks in a photoswipe-gallery are triggering photoswipe
• For each of this wrong link a broken photoswipe modal slide exists with "The image could not be loaded." message

I'll prepare a fix!

I also created an issue over at photoswipe: https://github.com/dimsemenov/PhotoSwipe/issues/2064

Here we go! Such a simple fix... -.-

Looks fine!

Tagging a new release!

Automatically closed - issue fixed for 2 weeks with no activity.