Libraries using jquery_ui assets directly shouldn't duplicate files

I have not manually tested this, but I think this is the minimal change required to extract common files from the two libraries still using jQuery.UI components to a common internal library.

😔

The test failure is for a test added explicitly for the old approach, we can probably just remove that test.

The change looks more minimal than I expected which is encouraging.

The test failure was pretty easily resolved by updating the setup to include the shared library's assets, and I think it still helpfully confirms that the assets aren't incorrectly ordered after this change.

Oh very nice!

I don't think there's anything else left here, so moving to RTBC. This means I can't directly commit it, but I will if there's an additional +1.

Committed 02630b5 and pushed to 11.x. Thanks!

Glad to see this committed! Hopefully it's an oversight, but I spent a very long time tracking this bug down, coming up with the steps to reproduce, etc so would have been great to have credit for this :)

Also, should we not backport this to 10.1?

Here's a reroll for 10.1.x

Yes that's my bad

No worries @nod_, it happens!

Reroll for 10.1.x looks good.

Gin admin theme needs this too, has exactly the same problem with core.css, see #3387363

Went ahead and committed/pushed the 10.1.x patch given this fixes a regression in that branch, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.