- Issue created by @grasmash
- π¬π§United Kingdom ipwa
Marking β¨ Possibility to make manual slider settings. Closed: duplicate as duplicate since this has more details.
- π¬π§United Kingdom ipwa
That sound great Mathew we really appreciate this contribution! We do want to keep the config we've exposed as fields we will be adding a lot more options but having the ability to add your own config as JSON sounds really great to us.
- @grasmash opened merge request.
- πΊπΈUnited States grasmash
I've submitted the MR but I understand that the changes I made don't align with your plan. My approach was to replace existing config fields with a single JSON field. Alternatively, perhaps we could add a field like "Config mode" that lets the the user can choose between defining config as JSON or as fields. Fields would be displayed conditionally based on that decision.
- Status changed to Needs work
about 1 year ago 5:41pm 25 August 2023 - π¬π§United Kingdom ipwa
Alternatively, perhaps we could add a field like "Config mode" that lets the the user can choose between defining config as JSON or as fields. Fields would be displayed conditionally based on that decision.
That approach sounds good, if you add that to your merge request I'd be happy to review and merge. Thanks for your work it is appreciated!
- @grasmash opened merge request.
- Status changed to Needs review
about 1 year ago 3:40pm 6 October 2023 - π¬π§United Kingdom endrukk
I created a new merge request which is building on the one in #8. There is an optional Config JSON field in the settings, if it has a valid JSON object, Tiny slider settings are overwritten by the JSON.
- π¬π§United Kingdom endrukk
I extended my merge request. There is an Advanced mode toggle which enables the free text field and hides other fields. A slight improvement on the UI.
- Status changed to Needs work
11 months ago 4:51am 13 December 2023 - πΊπΈUnited States brooke_heaton
The MR failed and the patch is not applying to 1.1.x-dev.
- Status changed to Needs review
11 months ago 9:52pm 21 December 2023 - π¬π§United Kingdom ipwa
This is the merge request: https://git.drupalcode.org/project/tiny_slider/-/merge_requests/15
- Status changed to RTBC
9 months ago 5:55am 28 February 2024 -
ipwa β
committed e4d3c9f0 on 1.1.x authored by
endrukk β
Issue #3382375 by grasmash, ipwa, endrukk: Change setting to accept JSON
-
ipwa β
committed e4d3c9f0 on 1.1.x authored by
endrukk β
- Status changed to Fixed
9 months ago 6:00am 28 February 2024 - π¬π§United Kingdom ipwa
Thanks Matthew for getting this started and Endre for bringing it over the line, great contributions!
Automatically closed - issue fixed for 2 weeks with no activity.
- πΊπΈUnited States Peter Caritas
I'm attempting to use the advanced mode feature and manually override configuration with json settings. After saving the view, the json settings field is set to null and the view is unchanged. Although, the advanced mode checkbox remains checked. Am I using this correctly?
Here are the json settings I'm adding:
[ default_row_class: true, center: false, mode: carousel, prevButton: '.prev', nextButton: '.next', nav: true, navPosition: 'bottom', loop: true, items: 1, gutter: 0, slideBy: 1, autoplay: true, autoplayTimeout: 12000, autoplayHoverPause: true, itemsDesktop: 1, itemsMobile: 1, ]
- π¨π¦Canada bohemier QuΓ©bec city, Qc
@peter your json is invalid. Try this:
{
"default_row_class": true,
"center": false,
"mode": "carousel",
"prevButton": ".prev",
"nextButton": ".next",
"nav": true,
"navPosition": "bottom",
"loop": true,
"items": 1,
"gutter": 0,
"slideBy": 1,
"autoplay": true,
"autoplayTimeout": 12000,
"autoplayHoverPause": true,
"itemsDesktop": 1,
"itemsMobile": 1
}