Taxonomy Access Control Hierarch does not submit configuration form correctly if entity bundle contains colon (:) - move towards a sequence of mappings for the field names schema

putting in review

Colons are not allowed in bundle machine names. See https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...

replace_pattern: (optional) A regular expression (without delimiters) matching disallowed characters in the machine name. Defaults to '[^a-z0-9_]+'.

This is a won't fix on this side. I would suggest that you update your module code. We are not adding an exception handler for this case.

If you want to use the patch, you can, but it will not be committed.

Thank you for looking into it @agentrickard.

Yes, machine name can't have : but plugins derivative separator is : and if an entity type uses bundle plugin then bundle name can have : in it.

I'd like to get @larowlan thoughts on this, as a co-maintainer of both modules, as he added bundle plugin functionality to data pipelines. I'm happy to change data pipelines module implementation but any entity using bundle plugin, I think all the entity types created using ECK use bundle plugin, will run into the same problem if wba support is enabled.

Content types don't support :, but other bundles certainly can.

The issue here is I used : to delimit the field name, bundle and entity type because I was having difficulty making a sequence of keyed items in the schema.

I now know there's a better way to do that. It would be painful, but really we should migrate the fields list to be a sequence of mappings (e.g. with keys field_name, bundle and entity_type). It would clean up the schema and remove all the code for casting to and from the : version.

It would however, require an update path.

OK - thanks for the clarifications.

Perhaps in the interim we should commit this patch -- and then open a new ticket for the task of changing the overall handling.

It would however, require an update path.

NW for this.