- Issue created by @PrasadDeole
- last update
over 1 year ago 21 pass - Status changed to Needs review
over 1 year ago 6:33pm 20 August 2023 - ๐ฎ๐ณIndia PrasadDeole
Issue summary updated and included DrupalPractice.
- last update
over 1 year ago 10 pass, 1 fail The last submitted patch, 5: coding-standard-3382137-5.patch, failed testing. View results โ
- Status changed to Needs work
over 1 year ago 7:22pm 20 August 2023 - ๐ท๐บRussia zniki.ru
zniki.ru โ made their first commit to this issueโs fork.
- last update
over 1 year ago 10 pass, 1 fail - First commit to issue fork.
- last update
over 1 year ago 10 pass, 1 fail - Status changed to Needs review
over 1 year ago 1:26pm 21 December 2023 - ๐ท๐บRussia zniki.ru
Same changes made in ๐ Fix linting errors on gitlab CI Needs review for 4.x branch. Not sure if we need to close this issue.
- Issue was unassigned.
- Status changed to RTBC
8 months ago 2:27am 14 August 2024 Hi @nitin_lama,
Applied the latest changes committed on MR!29, it was applied successfully and confirmed no errors reported.
simplesamlphp_auth git:(8.x-3.x) curl https://git.drupalcode.org/project/simplesamlphp_auth/-/merge_requests/29.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 20722 0 20722 0 0 52102 0 --:--:-- --:--:-- --:--:-- 53545 patching file simplesamlphp_auth.api.php patching file simplesamlphp_auth.install patching file simplesamlphp_auth.module patching file src/Controller/SimplesamlphpAuthController.php patching file src/EventSubscriber/SimplesamlExternalauthSubscriber.php patching file src/EventSubscriber/SimplesamlSubscriber.php patching file src/Exception/SimplesamlphpAttributeException.php patching file src/Plugin/Block/SimplesamlphpAuthBlock.php patching file src/Service/SimplesamlphpAuthManager.php patching file src/Service/SimplesamlphpDrupalAuth.php patching file tests/src/Functional/SimplesamlphpAuthTest.php patching file tests/src/Unit/Service/SimplesamlphpAuthManagerTest.php patching file tests/src/Unit/Service/SimplesamlphpDrupalAuthTest.php โ simplesamlphp_auth git:(8.x-3.x) โ .. โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simplesamlphp_auth โ contrib git:(master) โ
Will now move this to RTBC
Thanks,
Jake