[Drupal 10.1] Deprecated code

LOL, @Heddn, I was about to immediately close this ticket because I think having individual tickets for deprecations that will most likely be fixed via automation is unnecessary. I am starting to see people looking for some commit credit from these types of one-off fixes. I know you are not looking for commit credit. Do you think a dedicated ticket is needed?

I opened this because I wondered how you wanted to handle things. I personally prefer to incrementally keep up w/ deprecations so it isn't a huge rush at the end. I enabled tests on my client sites and they all surface these deprecations. So I either have to ignore them or open an issue so incrementally the site becomes less deprecated over time.

@heddn Since we are both aware that people are creating a lot of MRs to fix deprecated code for individual issues. How about we change this ticket and MR to address all Drupal 10.1 deprecating notices?

The concern w/ making is a 10.1 grouped item, how do we know what parts of 10.1 are affected? I guess we can add a test run on 10.1 and see what complains. Works for me. Back to active waiting on a patch.

I've been doing a review of deprecated code by using the Upgrade Status module report. I got around 47 issues for Webform (beta6), here I'm leaving some fixes hoping this will be reviewed and tested. It remains 13 issues that need review.

@afsch I appreciate the patch, but I think it is doing too many undocumented changes.

I am pretty sure the below code will break CAPTCHA support.

-      $element['#captcha_type'] = 'image_captcha/Image';
+      $element['#captcha_type'] = '/image_captcha/Image';

What might help is exporting and attaching the report.

BTW, I haven't used the Upgrade Status module report in a while so I am not sure how the report is structured.

@jrockowitz you are right, most of the updated lines where libraries are being loaded are incorrect.
Anyway, I'm hiding the patch file for now and attaching the report generated by Upgrade Status.

This change necessitates setting a minimum of Drupal 10.1.