Add compatibility with Group 3.x

I tested the fork for issue 💬 Is group content moderation module compatible with Groups 2.0.0-beta3? Needs work and it does indeed appear to work with Group 3.x

this was working for me until a commit to the issue fork for 💬 Is group content moderation module compatible with Groups 2.0.0-beta3? Needs work was made to remove compatabilty for Group 3.x.

jrglasgow → closed merge request !12

I have the fork with branch 3381073-group-3-compatible based on the work for 💬 Is group content moderation module compatible with Groups 2.0.0-beta3? Needs work but the references to group_content and group_content_type were changes to group_relationship and group_relationship_types.

I have a question. Is a way to apply correctly?

Tried the following:

"drupal/gcontent_moderation": "1.x-dev@dev",
"drupal/group": "3.2.0 as 1.0",

"drupal/gcontent_moderation": {
  "3381073: Make compatible with Group 3.x": "https://git.drupalcode.org/project/gcontent_moderation/-/merge_requests/13.diff"
},

However on /admin/structure/views/view/moderated_group_content see "Broken/missing handler".

Thank you.

@Ruslan Piskarov
Instead of adding the diff for this fork as a patch, instead you should add this fork as a repository in your composer. I ust updated the description of this issue with that information.

Don't require "drupal/group": "3.2.0 as 1.0",, leave it is ~3.1.0 for the time being... I haven't yet successfully made changes to this fork with group ^3.2 - that is for later today. I have had issues, but ^3.1.0 appears to be working with my latest commit.

I have created a new tag 3.0.0-beta3 with the latest commit to he fork so composer require drupal/gcontent_moderation ^3.0@beta should bring in the latest beta tag in the branch.

Thank you @jrglasgow.
On path like /group/11797046/moderated I still see the fatal error. I made a commit and now it works. Could you review it?

Also I manually fixed the "Moderated group content" view. Was Broken/Missing filter. Re-added but didn't commit.

I had created a separate issue about a typo causing /node/xxx/latest to always be blocked but realised this seemed to be the place to raise it.

https://www.drupal.org/project/gcontent_moderation/issues/3393691 🐛 Typo in LatestRevisionCheck blocks Latest Version route Closed: duplicate

I've made a commit to the MR that fixes the typo.

Moving this to N/W to fix the tests and missing coding standards

N/W to fix the tests

I think I got the last of the tests passing. Setting to "Needs Review".

Changes looks good to me.
Small changes required to accomodated phpstan issues here https://git.drupalcode.org/issue/gcontent_moderation-3381073/-/jobs/250922

Small changes required to accomodated phpstan issues here https://git.drupalcode.org/issue/gcontent_moderation-3381073/-/jobs/250922

@naveenvalecha I saw the phpstan issues, but they are not related to the 3.x support upgrade and are present in the 2.x branch.

One of them has an existing issue: https://www.drupal.org/project/gcontent_moderation/issues/3373812 📌 \Drupal calls should be avoided in classes, use dependency injection instead Needs review

Two others are related to 10.1 core deprecations which can't be changed without affecting the existing 9.x and 10.0 compatibility of the module.

I think these would be better done in separate issues where they can be updated for all support versions of the gcontent_moderation module.

I think these would be better done in separate issues where they can be updated for all support versions of the gcontent_moderation module.

Looks good in that case

MR has been merged to 3.0.x
It will be rolled out in next release.
Thanks everyone.

Automatically closed - issue fixed for 2 weeks with no activity.