Modify 'access content' permission to 'enable' this module

Good point. While it's kind of typical to have this permission set for anonymous on regular public projects, this might not be self-explaining. But instead of writing documentation, I'd instead just introduce a new permission, granted to anyone by update hook, who had "access content" before.

"Access PWA" (machine name: "access pwa")
"Allows to use the Progressive Web App. Technically this permission does ..."

Then it's totally clear, I think. Still I'd see this as minor SBX/UX-flaw.

I just thought about this again. Should we eventually just remove the permission check entirely and add an option to enable this permission check instead?

I just thought about this again. Should we eventually just remove the permission check entirely and add an option to enable this permission check instead?
That would mean, it's not by role. If yes, it's what permissions are supposed to do.

What are the pro's / con's?

Well, currently it is completely unclear, that pwa's functionality is even "guarded" by a permission at all. It isn't mentioned anywhere, and not what you would generally expect. Which leads to users not having the required permission set on, e.g. anonymous users and wondering why the module doesn't do anything (see 🐛 Anonymous Users Unable to Install Progressive Web App Fixed for example).

As the permission check isn't mentioned anywhere, nobody knows, that it exists. Meaning we could simply remove it entirely and make it an optional feature.

As "access content" is usually set for all roles, we would only kill the niche, where it isn't set and for the even smaller niche of people, who KNOW, that "access content" affects pwa and the removed it purposely for anonymous users, to avoid pwa to trigger (which probably doesn't exist), we could add an update hook enabling the permission option and granting every user with "access content" the new permission.

I still think #2 is the best and most clear way, let's discuss this personally tomorrow @Grevil!

Alright, let's do it like this!

All done, please review!

Very well done! Just some final text polishing!

All done! Please rereview! :)

T

Automatically closed - issue fixed for 2 weeks with no activity.