- Issue created by @Grevil
- 🇩🇪Germany Anybody Porta Westfalica
Good point. While it's kind of typical to have this permission set for anonymous on regular public projects, this might not be self-explaining. But instead of writing documentation, I'd instead just introduce a new permission, granted to anyone by update hook, who had "access content" before.
"Access PWA" (machine name: "access pwa")
"Allows to use the Progressive Web App. Technically this permission does ..."Then it's totally clear, I think. Still I'd see this as minor SBX/UX-flaw.
- last update
over 1 year ago 1 pass - @grevil opened merge request.
- last update
over 1 year ago 1 pass, 2 fail - 🇩🇪Germany Grevil
I just thought about this again. Should we eventually just remove the permission check entirely and add an option to enable this permission check instead?
- 🇩🇪Germany Anybody Porta Westfalica
I just thought about this again. Should we eventually just remove the permission check entirely and add an option to enable this permission check instead?
That would mean, it's not by role. If yes, it's what permissions are supposed to do.What are the pro's / con's?
- 🇩🇪Germany Grevil
Well, currently it is completely unclear, that pwa's functionality is even "guarded" by a permission at all. It isn't mentioned anywhere, and not what you would generally expect. Which leads to users not having the required permission set on, e.g. anonymous users and wondering why the module doesn't do anything (see 🐛 Anonymous Users Unable to Install Progressive Web App Fixed for example).
As the permission check isn't mentioned anywhere, nobody knows, that it exists. Meaning we could simply remove it entirely and make it an optional feature.
As "access content" is usually set for all roles, we would only kill the niche, where it isn't set and for the even smaller niche of people, who KNOW, that "access content" affects pwa and the removed it purposely for anonymous users, to avoid pwa to trigger (which probably doesn't exist), we could add an update hook enabling the permission option and granting every user with "access content" the new permission.
- Assigned to Anybody
- Assigned to Grevil
- last update
over 1 year ago 9 pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 9 pass - last update
over 1 year ago 9 pass - Status changed to Needs review
over 1 year ago 9:49am 8 September 2023 - Status changed to Needs work
over 1 year ago 9:56am 8 September 2023 - 🇩🇪Germany Anybody Porta Westfalica
Very well done! Just some final text polishing!
- last update
over 1 year ago 9 pass - Status changed to Needs review
over 1 year ago 10:35am 8 September 2023 - Issue was unassigned.
- Status changed to Fixed
over 1 year ago 10:47am 8 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.