Contrib.social

Change the logic for Background Edge to Edge style plugin after change of logic for rendering both Background Color and Background Image or video

Open on Drupal.org →
Created on 10 August 2023, over 1 year ago
Updated 10 September 2023, about 1 year ago

Problem/Motivation

After applying this patch 🐛 Fix rendering both Background Color and Background Image or Video Fixed we need to change the logic for edge-to-edge style

Steps to reproduce

1- Apply the patch
2- Add bg image
3- add bg color
4- remove the bg image
Edge-to-edge class not render.

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.15 → , varbase_layout_builder-10.0.31 → , Varbase 10.0.0-beta1 → , varbase_layout_builder-10.1.0-alpha9 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the Fix:

Tested with Varbase ~10.0.0 and Drupal ~10.1.0

Varbase ~10.0.0 Test Section Backgrounds - Edge to Edge Background
→

Varbase ~10.0.0 Test Section Backgrounds - NO Edge to Edge Background
→

Varbase ~10.0.0 Edit Section - Background Color and Background Image
→

Varbase ~10.0.0 Edit Section - Background Color and Background Image - NO Edge to Edge Background
→

Tested with Varbase ~9.0.0 and Drupal ~9.5.0

Varbase ~9.0.0 Test Section Backgrounds - Edge to Edge Background
→

Varbase ~9.0.0 Test Section Backgrounds - NO Edge to Edge Background
→

Varbase ~9.0.0 Edit Section - Background Color and Background Image
→

Varbase ~9.0.0 Edit Section - Background Color and Background Image - NO Edge to Edge Background
→

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3380384 → by Ahmad Abbad → : Changed the logic for Background Edge to Edge style plugin after change of logic for rendering both Background Color and Background Image or video
📌 Task
Status

Fixed

Version

10.0

Component

Code

Created by

🇯🇴Jordan ahmad abbad Jordan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024