- π―π΄Jordan ahmad abbad Jordan
I'm facing the same problem where if I add the image first and then the background color, the background image disappears.
- Assigned to Rajab Natshah
- π―π΄Jordan Rajab Natshah Jordan
I confirm the issue!
The UI/UX behavior should match the chosen values. Have the status which following the settings UI selection. When all three options are set, they should all appear on the section on top of each other.
If the section settings form includes a Background Color, it should show on the page.
If a Background Image or Background Video in the section settings form was selected, it should render on the page.Steps to reproduce
Scenario: Configuring Background Image and Color in a Section
GivenBootstrap Styles
andBootstrap Layout Builder
are configured for a selected content
When an editor adds a new section
And selects aBackground Image
for the section
And saves the section configurations
Then the section will display the selected background image
When the editor edits the same section for the second time
And adds aBackground Color
to it
And saves the section configurations
Then the section will show theBackground Color
But not theBackground Image
When the editor edits the same section for the third time
Then thebackground Image
will still be present in the settings UI form element
When the editor saves only the section settings
Then theBackground Image
will be displayed
And the last selectedBackground Color
will not be displayed - π―π΄Jordan Rajab Natshah Jordan
Find out that the Background type is a filed type of radios
When editors click on the color, image, video tab option, they are selecting a radios form element value.
Which will be saved - @rajab-natshah opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:12pm 9 August 2023 - π―π΄Jordan Rajab Natshah Jordan
Needs more review and testing before committing
- β Testing to ensure no regression
- β Full testing and approval
- π―π΄Jordan ahmad abbad Jordan
After further testing and applying the patch to projects
I faced the following warningsWarning: Trying to access array offset on value of type null in Drupal\bootstrap_styles\Plugin\BootstrapStyles\Style\BackgroundColor->buildStyleFormElements() (line 62
Warning: Trying to access array offset on value of type null in Drupal\bootstrap_styles\Plugin\BootstrapStyles\Style\BackgroundColor->buildStyleFormElements() (line 61
Warning: Undefined array key "background" in Drupal\bootstrap_styles\Plugin\BootstrapStyles\Style\BackgroundColor->buildStyleFormElements() (line 62
Warning: Undefined array key "background" in Drupal\bootstrap_styles\Plugin\BootstrapStyles\Style\BackgroundColor->buildStyleFormElements() (line 62
- Status changed to Needs work
over 1 year ago 9:34am 22 August 2023 - π―π΄Jordan Rajab Natshah Jordan
Thanks, Ahmad, for testing and following up on the issue.
Our wait on committing came with good capturing of warnings and other issues
- Assigned to Rajab Natshah
- Status changed to Active
over 1 year ago 12:17pm 22 August 2023 -
Rajab Natshah β
committed 548ddb5a on 1.0.x
Issue #3221526: Fix rendering both Background Color and Background Image...
-
Rajab Natshah β
committed 548ddb5a on 1.0.x
- Issue was unassigned.
- Status changed to Fixed
over 1 year ago 5:47pm 12 September 2023 - π―π΄Jordan Rajab Natshah Jordan
β Released bootstrap_styles-1.1.2 β
Automatically closed - issue fixed for 2 weeks with no activity.