[2.1.x] Disclosure Menu

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

Remember to change the status to Needs review when the project is ready for review.

Thank you for applying. The project does not have any 2.1.x branch. Which branch should be reviewed?

@apaderno I updated the default branch to 2.1.x which can be reviewed here:
https://git.drupalcode.org/project/disclosure_menu/-/tree/2.1.x

FILE: src/Plugin/Block/DisclosureMenuBlock.php

  /**
   * Overrides \Drupal\block\BlockBase::defaultConfiguration().
   */
  public function defaultConfiguration() {

  /**
   * Overrides \Drupal\block\BlockBase::blockForm().
   */
  public function blockForm($form, FormStateInterface $form_state) {

  /**
   * Overrides \Drupal\block\BlockBase::blockSubmit().
   */
  public function blockSubmit($form, FormStateInterface $form_state) {

  /**
   * Implements \Drupal\block\BlockBase::build().
   */
  public function build() {

{@inheritdoc} is used if you are overriding or implementing a method from a base class or interface.

@vishal.kadam I updated those method doc blocks.
https://git.drupalcode.org/project/disclosure_menu/-/commit/5011dfc453cb...

Rest looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

No issues found
Changing status to RTBC!

    $form['disclosure_js']['include_default_js'] = [
      '#type' => 'radios',
      '#title' => $this->t('Include default Javascript'),
      '#description' => $this->t(
        'This will set disclosure buttons to toggle open submenus.'
      ),
      '#default_value' => $this->configuration['include_default_js'],
      '#options' => [
        1 => 'Yes',
        0 => 'No',
      ],
    ];

Option strings must be translated strings, similarly to what done with the other form fields, like the following one.

    $form['menu_disclosure']['menu_disclosure'] = [
      '#title' => $this->t('Add an additional disclosure button to toggle the entire menu?'),
      '#type' => 'radios',
      '#options' => [
        0 => $this->t('No'),
        1 => $this->t('Yes'),
      ],
      '#default_value' => $this->configuration['menu_disclosure'],
    ];

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries → ' post on Responsible maintainers
• Best practices for creating and maintaining projects →
• Maintaining a drupal.org project with Git →
• Commit messages - providing history and credit →
• Release naming conventions → .
• Helping maintainers in the issue queues →

You can find more contributors chatting on the Slack → #contribute channel. So, come hang out and stay involved → .
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank all the reviewers.

Thank you all so much!

Automatically closed - issue fixed for 2 weeks with no activity.