Node trigger button not visible in Gin dark mode.

Created on 8 August 2023, over 1 year ago
Updated 13 October 2023, about 1 year ago

Problem/Motivation

Gin dark mode /gin/dist/css/components/contextual_links.css override the css properties.

Steps to reproduce

  1. install gin theme
  2. Use claro as administration theme
  3. Create node by Article
  4. Preview the node on page

Proposed resolution

contextual .trigger::before {
    content: "";
    background: var(--gin-color-title);
}

This will allow to preview the button.

🐛 Bug report
Status

Closed: won't fix

Version

3.0

Component

Code

Created by

🇮🇳India djsagar

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @djsagar
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India djsagar

    I have done the changes and created patch please review.

    Regard!

  • 🇮🇳India djsagar

    Forgot to upload the patch file.

  • 🇮🇳India swatidhurandhar

    hi @djsagar I tried to test the patch but issue is not reproducible in D10.1 and D9.5.10. Can you provide detailed steps where this issue is reproducible so that I can test this patch?

  • 🇮🇳India Preeti.chawla

    @djsagar I have applied patch#3 and applied successfully, trigger button visible properly. Just want to highlight this trigger button was not working fine in light mode as well. After patch#3 working fine in both the cases. Adding screenshot of Light mode before patch
    We can move to RTBC+1

  • Status changed to RTBC over 1 year ago
  • Verified the #3 patch on 9.5.8, the edit icon is now visible. Added screenshots for reference, RTBC++

  • Status changed to Closed: won't fix about 1 year ago
  • 🇨🇭Switzerland saschaeggi Zurich

    I'm also unable to reproduce this.

    This won't work as when you set Claro as administration theme it can have side effects that Gin's CSS variables don't get loaded.

Production build 0.71.5 2024