- Issue created by @FeyP
- First commit to issue fork.
- last update
over 1 year ago Custom Commands Failed - @elber opened merge request.
- Status changed to Needs work
over 1 year ago 11:35am 8 August 2023 - 🇧🇷Brazil elber Brazil
Hi I just added the method to the interface, I will keep working on it .
feel free to work on it also.
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 29,953 pass - Status changed to Needs review
over 1 year ago 3:12pm 8 August 2023 - Status changed to Needs work
over 1 year ago 4:01pm 9 August 2023 - 🇺🇸United States smustgrave
New feature will need test coverage but this probably should wait until 🐛 Invalid argument exception when changing language of node with menu link to und or zxx Fixed
One comment I have since I created https://www.drupal.org/project/drupal/issues/3385550 🐛 Language negotiation breaks updating Drupal 9 to 10 Needs work :
I'm not sure it's a good idea to create the function: LanguageInterface::LANGCODE_NOT_APPLICABLE and LanguageInterface::LANGCODE_NOT_SPECIFIED are very different.- LANGCODE_NOT_APPLICABLE: I do not want to have a langcode even if it's setup in the system.
- LANGCODE_NOT_SPECIFIED: Langcode is not specified, but if there's an active langcode, add it.In most cases you would still have to distinguish between the 2 cases anyway.
- Status changed to Closed: works as designed
about 1 year ago 2:59am 15 November 2023 - 🇩🇪Germany FeyP
Thanks for working on this. @alexpott pointed out over in #2904899-29: Invalid argument exception when changing language of node with menu link to und or zxx → that you can actually use
$node->language()->isLocked(), if you need this, so I'm going to go ahead and close this as works as designed. Feel free to reopen, if you disagree.