Convert enable/disable to install/uninstall in UI not in hook_help

The last submitted patch, 2: 3379496-2.patch, failed testing. View results →

There were lots of strings changes needed in test files.

The last submitted patch, 4: 3379496-4.patch, failed testing. View results →

And some more test strings to change.

Restore use of 'enabled' when referring to legacy D6/D7 sites in migrate drupal ui.

Think this is good start and don't want to extend the patch.

I think a follow up should be opened for updating comments too. Checking the modules for folder for "enabled" I got 767 matches. Lot of Modules to enable. from tests.

The proposed resolution in the Meta includes doing the same for comments and variables.

The last submitted patch, 8: 3379496-8.patch, failed testing. View results →

Failure in an unrelated test, retesting.

1) Drupal\Tests\user\FunctionalJavascript\UserPermissionsTest::testPermissionCheckboxes
Failed asserting that false is true.

Does seems to be random, all green.

The last submitted patch, 8: 3379496-8.patch, failed testing. View results →

Unrelated fail, retesting.

1) Drupal\Tests\toolbar\FunctionalJavascript\ToolbarActiveTrailTest::testToolbarActiveTrail with data set #1 ('horizontal')
Failed asserting that false is true.

Tests passing again, back to RTBC

#8 shows the patch is out of date. That is because core/modules/system/tests/src/Functional/Module/InstallUninstallTest.php has been removed. There is a new base class for that functionality, \Drupal\Tests\system\Functional\Module\GenericModuleTestBase, and it correctly uses 'install' and 'uninstall'.

Therefor, I think this can stay at RTBC.

This appears to still be a reference to a disabled module:

core/modules/system/tests/src/Functional/Form/ModulesListFormWebTest.php:    $module_theme_depends_on_description = $this->getSession()->getPage()->findAll('css', '#edit-modules-test-module-required-by-theme-ena
ble-description .admin-requirements li:contains("Test Theme Depending on Modules (theme) (disabled)")');
core/modules/system/tests/src/Functional/Form/ModulesListFormWebTest.php:    $this->assertSession()->pageTextContains('Test Theme Depending on Modules (Theme) (Disabled)');

The following strings still refer to enabled modules:

core/modules/system/system.install:        'title' => t('Experimental modules enabled'),
core/modules/system/system.install:        'title' => t('Deprecated modules enabled'),
core/modules/system/system.install:        'title' => t('Experimental themes enabled'),
core/modules/system/system.install:        'title' => t('Deprecated themes enabled'),
core/modules/system/system.install:        'title' => t('Obsolete extensions enabled'),

core/modules/system/system.install:        'description' => t('Update notifications are not enabled. It is <strong>highly recommended</strong> that you enable the Update Manager module from the <a href=":module">module administration page</a> in order to stay up-to-date on new releases. For more information, <a href=":update">Update status handbook page</a>.', [

core/modules/system/system.install:            'description' => t('The current database driver is provided by the module: %module. The module is currently not enabled. You should immediately <a href=":enable">enable</a> the module.', ['%module' => $provider, ':enable' => Url::fromRoute('system.modules_list')->toString()]),

core/modules/language/language.module:        $additional_overview = t("If the Interface Translation module is enabled, this page will provide an overview of how much of the site's interface has been translated for each configured language.");

core/modules/editor/editor.module:    $form['editor']['editor']['#description'] = t('This option is disabled because no modules that provide a text editor are currently enabled.');

There may be more - but it is quite hard to grep the codebase without finding lots of false positives.

@longwave, thanks. I agree that searching for the ones to fix is not easy. And I am trying to complete the user facing ones first.

#20
first item. While this is testing the text in UI it is text from a test module and thus not something a user will see. I'd like to do that in a separate issue where searches for other such instances in tests can be done. For that, I have added this to the issue summary of the Meta.

second item. I have converted all the 'enabled' related to Drupal modules in system.install to 'installed'. I hope I got them all!

Seems previous feedback has been addressed

Committed db74af7 and pushed to 11.x. Thanks!

Not backportable to 10.2.x as this contains lots of translatable string changes.

quietone → closed merge request !4997

Automatically closed - issue fixed for 2 weeks with no activity.