- Issue created by @dbielke1986
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
- Status changed to Needs work
over 1 year ago 9:05am 6 August 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points. - 🇩🇪Germany vincent.hoehn Dresden, Germany
What is the recommended way now? I have made the most commits on the project, should I create a new issue?
- Status changed to Needs review
over 1 year ago 7:04am 7 August 2023 - Status changed to Needs work
over 1 year ago 8:17am 7 August 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
@vincent.hoehn Yes, you should be the one using this module for your application, which you can create since you cannot opt projects into security advisory coverage.
@dbielke1986 must use a different module. - Status changed to Closed: duplicate
over 1 year ago 9:05am 7 August 2023 - Status changed to Needs work
over 1 year ago 10:25am 7 August 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Actually, these are not duplicates because they are for two different people.
This application is for allowing dbielke1986 (you) to opt projects into security advisory coverage; the other application is for allowing vincent.hoehn to opt projects into security advisory coverage. These applications do not change the project status, but give to the person who created the application a new drupal.org permission, and only to the person who created the specific application. Other maintainers for the project used in the application will not gain any new drupal.org permission. - 🇩🇪Germany dbielke1986
@apaderno,
Ahhh, now I understand the process. Thank you for the clarification. Then I will have to wait a bit here to fill a branch with commits, mainly from me.
We pushed the feature branches into the main branch pretty quickly. If the ones from the Main Branch are not enough, then I will have to wait and code some more.
Thanks for the clarification!
- 🇮🇹Italy apaderno Brescia, 🇮🇹
You need also to use a different project, though.
- 🇮🇹Italy apaderno Brescia, 🇮🇹
I am changing priority as per Issue priorities → .
- Status changed to Closed: outdated
about 1 year ago 1:38pm 25 September 2023