- Issue created by @VijaySharma_89
- Status changed to Needs review
over 1 year ago 1:02pm 11 August 2023 - 🇮🇳India riddhi.addweb
I have applied the "3379275-2" patch cleanly but still, there are some errors.
Please check the screenshot for the same.FILE: /var/www/html/web/drupal10/web/themes/contrib/status_zymphonies_theme/status_zymphonies_theme.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/themes/contrib/status_zymphonies_theme/config/optional/block.block.status_zymphonies_theme_page_title.yml ---------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------------------- 17 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/themes/contrib/status_zymphonies_theme/config/install/status_zymphonies_theme.settings.yml ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 43 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/web/drupal10/web/themes/contrib/status_zymphonies_theme/status_zymphonies_theme.theme ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 61 ERRORS AND 14 WARNINGS AFFECTING 51 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 5 | ERROR | [x] Doc comment short description must end with a full stop 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Template\Attribute. 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 16 | WARNING | [x] Unused use statement 20 | ERROR | [x] There must be no blank lines after the function comment 28 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 39 | ERROR | [x] Use "elseif" in place of "else if" 42 | ERROR | [x] Use "elseif" in place of "else if" 42 | ERROR | [x] Expected 1 space after IF keyword; 0 found 53 | ERROR | [x] Use "elseif" in place of "else if" 56 | ERROR | [x] Use "elseif" in place of "else if" 56 | ERROR | [x] Expected 1 space after IF keyword; 0 found 67 | ERROR | [x] Use "elseif" in place of "else if" 70 | ERROR | [x] Use "elseif" in place of "else if" 70 | ERROR | [x] Expected 1 space after IF keyword; 0 found 82 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 94 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 128 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 129 | ERROR | [x] Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces 132 | ERROR | [x] Whitespace found at end of line 134 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 136 | ERROR | [x] Expected one space after the comma, 0 found 148 | ERROR | [x] There should be no white space after an opening "{" 148 | ERROR | [x] Comments may not appear after statements 155 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 156 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 164 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 169 | ERROR | [x] Concat operator must be surrounded by a single space 169 | ERROR | [x] Expected one space after the comma, 0 found 181 | ERROR | [x] Concat operator must be surrounded by a single space 182 | ERROR | [x] Concat operator must be surrounded by a single space 193 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements 196 | WARNING | [x] A comma should follow the last multiline array item. Found: '<h2><br/>Advanced Theme Settings</h2><div class="messages messages--warning">Clear cache after making any changes in | | theme settings. <a href="../../config/development/performance">Click here to clear cache</a></div>' 199 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 238 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 251 | ERROR | [x] Whitespace found at end of line 252 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses 252 | ERROR | [x] Whitespace found at end of line 275 | ERROR | [x] Whitespace found at end of line 279 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 279 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 279 | ERROR | [x] Concat operator must be surrounded by a single space 285 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 285 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 285 | ERROR | [x] Concat operator must be surrounded by a single space 285 | ERROR | [x] Concat operator must be surrounded by a single space 286 | ERROR | [x] Concat operator must be surrounded by a single space 286 | ERROR | [x] Expected one space after the comma, 0 found 291 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 291 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 291 | ERROR | [x] Concat operator must be surrounded by a single space 291 | ERROR | [x] Concat operator must be surrounded by a single space 292 | ERROR | [x] Expected one space after the comma, 0 found 296 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 296 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 296 | ERROR | [x] Concat operator must be surrounded by a single space 296 | ERROR | [x] Concat operator must be surrounded by a single space 297 | ERROR | [x] Expected one space after the comma, 0 found 298 | ERROR | [x] Whitespace found at end of line 301 | WARNING | [ ] Translatable strings must not begin or end with white spaces, use placeholders with t() for variables 301 | ERROR | [ ] Concatenating translatable strings is not allowed, use placeholders instead and only one string literal 301 | ERROR | [x] Concat operator must be surrounded by a single space 301 | ERROR | [x] Concat operator must be surrounded by a single space 302 | ERROR | [x] Expected one space after the comma, 0 found 306 | ERROR | [x] Concat operator must be surrounded by a single space 306 | ERROR | [x] Expected one space after the comma, 0 found 307 | ERROR | [x] Expected 1 space after IF keyword; 0 found 307 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 319 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 64 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/web/drupal10/web/themes/contrib/status_zymphonies_theme/templates/layout/page.html.twig ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 254 | ERROR | [x] Expected 1 newline at end of file; 3 found ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- - Status changed to Needs work
5 months ago 12:42am 24 July 2024 - 🇵🇭Philippines clarkssquared
Hi
I also applied patch #2 and I can confirm with comment #3 that there's still PHPCS issues in the theme.
➜ status_zymphonies_theme git:(main) ✗ curl https://www.drupal.org/files/issues/2023-08-11/3379275-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 183k 100 183k 0 0 325k 0 --:--:-- --:--:-- --:--:-- 328k patching file 'css/global.css' patching file 'css/media.css' patching file 'includes/fontawesome/css/fontawesome-all.css' patching file 'includes/masonry/js/imagesloaded.pkgd.js' patching file 'includes/masonry/js/masonry.pkgd.js' patching file 'includes/owl/assets/owl.carousel.css' patching file 'includes/smartmenus/sm-core-css.css' patching file 'js/custom.js' ➜ status_zymphonies_theme git:(main) ✗ .. ➜ contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml status_zymphonies_theme FILE: ...l/web/themes/contrib/status_zymphonies_theme/status_zymphonies_theme.theme -------------------------------------------------------------------------------- FOUND 61 ERRORS AND 14 WARNINGS AFFECTING 51 LINES -------------------------------------------------------------------------------- 5 | ERROR | [x] Doc comment short description must end with a full stop 8 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 9 | ERROR | [x] Use statements should be sorted alphabetically. The first | | wrong one is Drupal\Core\Template\Attribute. 10 | WARNING | [x] Unused use statement 11 | WARNING | [x] Unused use statement 12 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 15 | WARNING | [x] Unused use statement 16 | WARNING | [x] Unused use statement 20 | ERROR | [x] There must be no blank lines after the function comment 28 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 39 | ERROR | [x] Use "elseif" in place of "else if" 42 | ERROR | [x] Use "elseif" in place of "else if" 42 | ERROR | [x] Expected 1 space after IF keyword; 0 found 53 | ERROR | [x] Use "elseif" in place of "else if" 56 | ERROR | [x] Use "elseif" in place of "else if" 56 | ERROR | [x] Expected 1 space after IF keyword; 0 found 67 | ERROR | [x] Use "elseif" in place of "else if" 70 | ERROR | [x] Use "elseif" in place of "else if" 70 | ERROR | [x] Expected 1 space after IF keyword; 0 found 82 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 94 | ERROR | [x] Expected 1 space after ELSEIF keyword; 0 found 128 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 129 | ERROR | [x] Equals sign not aligned with surrounding assignments; | | expected 1 space but found 2 spaces 132 | ERROR | [x] Whitespace found at end of line 134 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 136 | ERROR | [x] Expected one space after the comma, 0 found 148 | ERROR | [x] There should be no white space after an opening "{" 148 | ERROR | [x] Comments may not appear after statements 155 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 156 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 164 | ERROR | [ ] Doc comment short description must be on a single line, | | further text should be a separate paragraph 169 | ERROR | [x] Concat operator must be surrounded by a single space 169 | ERROR | [x] Expected one space after the comma, 0 found 181 | ERROR | [x] Concat operator must be surrounded by a single space 182 | ERROR | [x] Concat operator must be surrounded by a single space 193 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced | | with use statements 196 | WARNING | [x] A comma should follow the last multiline array item. | | Found: '<h2><br/>Advanced Theme Settings</h2><div | | class="messages messages--warning">Clear cache after | | making any changes in theme settings. <a | | href="../../config/development/performance">Click here to | | clear cache</a></div>' 199 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 238 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 251 | ERROR | [x] Whitespace found at end of line 252 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, | | question marks, colons, or closing parentheses 252 | ERROR | [x] Whitespace found at end of line 275 | ERROR | [x] Whitespace found at end of line 279 | WARNING | [ ] Translatable strings must not begin or end with white | | spaces, use placeholders with t() for variables 279 | ERROR | [ ] Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 279 | ERROR | [x] Concat operator must be surrounded by a single space 285 | WARNING | [ ] Translatable strings must not begin or end with white | | spaces, use placeholders with t() for variables 285 | ERROR | [ ] Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 285 | ERROR | [x] Concat operator must be surrounded by a single space 285 | ERROR | [x] Concat operator must be surrounded by a single space 286 | ERROR | [x] Concat operator must be surrounded by a single space 286 | ERROR | [x] Expected one space after the comma, 0 found 291 | WARNING | [ ] Translatable strings must not begin or end with white | | spaces, use placeholders with t() for variables 291 | ERROR | [ ] Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 291 | ERROR | [x] Concat operator must be surrounded by a single space 291 | ERROR | [x] Concat operator must be surrounded by a single space 292 | ERROR | [x] Expected one space after the comma, 0 found 296 | WARNING | [ ] Translatable strings must not begin or end with white | | spaces, use placeholders with t() for variables 296 | ERROR | [ ] Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 296 | ERROR | [x] Concat operator must be surrounded by a single space 296 | ERROR | [x] Concat operator must be surrounded by a single space 297 | ERROR | [x] Expected one space after the comma, 0 found 298 | ERROR | [x] Whitespace found at end of line 301 | WARNING | [ ] Translatable strings must not begin or end with white | | spaces, use placeholders with t() for variables 301 | ERROR | [ ] Concatenating translatable strings is not allowed, use | | placeholders instead and only one string literal 301 | ERROR | [x] Concat operator must be surrounded by a single space 301 | ERROR | [x] Concat operator must be surrounded by a single space 302 | ERROR | [x] Expected one space after the comma, 0 found 306 | ERROR | [x] Concat operator must be surrounded by a single space 306 | ERROR | [x] Expected one space after the comma, 0 found 307 | ERROR | [x] Expected 1 space after IF keyword; 0 found 307 | ERROR | [x] Expected 1 space after closing parenthesis; found 0 319 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 64 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...tatus_zymphonies_theme/config/install/status_zymphonies_theme.settings.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 43 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...s_theme/config/optional/block.block.status_zymphonies_theme_page_title.yml -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 17 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...eb/themes/contrib/status_zymphonies_theme/status_zymphonies_theme.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by | | drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by | | drupal.org packaging automatically -------------------------------------------------------------------------------- Time: 651ms; Memory: 24MB ➜ contrib git:(main) ✗I will move this ticket to needs work and also can you create a MR based on your patch so that the maintainer can conveniently look at it once it passes with the community? Thanks.
- 🇮🇳India dev2.addweb
nilesh.addweb → made their first commit to this issue’s fork.
- Status changed to Needs review
5 months ago 6:51am 24 July 2024 - Status changed to RTBC
5 months ago 11:01am 24 July 2024 - 🇮🇳India riddhi.addweb
The mentioned page issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.