- Issue created by @malcomio
- last update
10 months ago 3 pass - @malcomio opened merge request.
- Status changed to Needs review
10 months ago 2:02pm 16 August 2023 - last update
10 months ago 3 pass - last update
10 months ago 3 pass - Status changed to RTBC
10 months ago 1:09pm 22 August 2023 RTBC for the merge request. I didn't use the patch; I used the MR's patch file. Very nice! I like it!
Personally, I think it'd be nice if the button text could be customized in the view settings, though I don't need to use that.
For some reason it didn't apply when I used 8.x-1.3, but it did apply to dev. They should be equal right now, though...
- 🇩🇰Denmark ressa Copenhagen
+1 RTBC for the Gitlab patch "MR !24". It works fine with the dev-version. (Doesn't apply with the latest release 1.4)
- 🇧🇪Belgium DieterHolvoet Brussels
I'm not sure if it makes sense to style it as a regular button and to keep it in the feed icon region. Before, it matched the style of other feed icons, now not anymore. A better solution IMO would be to add a local action (button in de top right region of the screen), but I'm not sure if this is possible in views.
- 🇧🇪Belgium DieterHolvoet Brussels
I created a new issue since the scope is way different than this one: ✨ Add export links as local actions instead of feed icons Active .
- Status changed to Closed: outdated
5 months ago 5:20pm 11 January 2024 - 🇩🇰Denmark ressa Copenhagen
Great idea @DieterHolvoet, I very much agree that the position in the lower left corner is not ideal. Perhaps this issue should even be closed, and further work done in ✨ Add export links as local actions instead of feed icons Active ?
I think the feasibility of that type of solution should be evaluated. If it's not possible for filters to be taken into account, then having the button at the bottom is preferrable.
- Status changed to RTBC
5 months ago 5:44pm 11 January 2024 - 🇧🇪Belgium DieterHolvoet Brussels
@ressa While I do agree with you, we should probably leave it up to the maintainer to decide which solution to go for.
- 🇩🇰Denmark ressa Copenhagen
Sure, no problem :) Though, as far as I can tell, no maintainer has yet participated in this issue. It could be changed to Postponed?