- Issue created by @malcomio
- last update
over 1 year ago 3 pass - Status changed to Needs review
over 1 year ago 2:02pm 16 August 2023 - last update
over 1 year ago 3 pass - last update
over 1 year ago 3 pass - Status changed to RTBC
over 1 year ago 1:09pm 22 August 2023 RTBC for the merge request. I didn't use the patch; I used the MR's patch file. Very nice! I like it!
Personally, I think it'd be nice if the button text could be customized in the view settings, though I don't need to use that.
For some reason it didn't apply when I used 8.x-1.3, but it did apply to dev. They should be equal right now, though...
- 🇩🇰Denmark ressa Copenhagen
+1 RTBC for the Gitlab patch "MR !24". It works fine with the dev-version. (Doesn't apply with the latest release 1.4)
- 🇧🇪Belgium dieterholvoet Brussels
I'm not sure if it makes sense to style it as a regular button and to keep it in the feed icon region. Before, it matched the style of other feed icons, now not anymore. A better solution IMO would be to add a local action (button in de top right region of the screen), but I'm not sure if this is possible in views.
- 🇧🇪Belgium dieterholvoet Brussels
I created a new issue since the scope is way different than this one: ✨ Add export links as local actions instead of feed icons Active .
- Status changed to Closed: outdated
about 1 year ago 5:20pm 11 January 2024 - 🇩🇰Denmark ressa Copenhagen
Great idea @DieterHolvoet, I very much agree that the position in the lower left corner is not ideal. Perhaps this issue should even be closed, and further work done in ✨ Add export links as local actions instead of feed icons Active ?
I think the feasibility of that type of solution should be evaluated. If it's not possible for filters to be taken into account, then having the button at the bottom is preferrable.
- Status changed to RTBC
about 1 year ago 5:44pm 11 January 2024 - 🇧🇪Belgium dieterholvoet Brussels
@ressa While I do agree with you, we should probably leave it up to the maintainer to decide which solution to go for.
- 🇩🇰Denmark ressa Copenhagen
Sure, no problem :) Though, as far as I can tell, no maintainer has yet participated in this issue. It could be changed to Postponed?
- 🇬🇧United Kingdom steven jones
This seems like a great change to me, but is a breaking change, so we should bump the version of the module I reckon.
-
Steven Jones →
committed 262b5885 on 8.x-2.x authored by
malcomio →
Issue #3379233: Increase size of download buttons
-
Steven Jones →
committed 262b5885 on 8.x-2.x authored by
malcomio →
- Status changed to Fixed
8 months ago 7:20pm 21 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇳China skyredwang Shanghai
#22 patch wasn't created with a
--binary
flag, so it won't apply. This one works. - 🇨🇳China skyredwang Shanghai
I lied again. With binary files, the patch appears to only apply when the index matches the point when the patch was created.
- 🇬🇧United Kingdom steven jones
So I had a little play with at site of ours...and actually this change made the view buttons look a decent amount worse.
I've had a sort of re-think, but I think I'll continue discussion in ✨ Add export links as local actions instead of feed icons Active
It makes the buttons follow the site's theme and adjusts them to be themeable, so you can style them however you want. On my site, it makes the buttons look like literally every other button on the site.