Remove "match" expression, so the module is also PHP < 8 compatible.

I'd suggest dropping php <8 support, 7.4 is not supported for almost half a year and Drupal 9 will be dropped in November.

True! But I think this makes the code a bit cleaner (and a bit more performant), and we still support PHP 7.4 for the remaining few months!

Please review.

But I think this makes the code a bit cleaner

Match was added into the language to make code cleaner if else / switch are not as clean as match as for me.

and a bit more performant

I'm not sure about this.

I left one comment, once it will be fixed +1 RTBC.

Please take a look, I think it's nice and self-explaining this way. To be honest, I think match() is personal preference or dislike, bit the code now should be very self-explaining to anyone?

We shouldn't do it for the PHP <8 compatibility, but if we can have both, that's nice.

All fine and still working as expected?

No, dependency won't be undefined. We either have cdn enabled and $dependency will be "photoswipe/photoswipe.cdn" or it is not enabled and $dependency will be set to "photoswipe/photoswipe.local".
Even clearer now, where we use local as default and removed the if.

Looks great now +1 RTBC

and a bit more performant

I'm not sure about this.

We completely remove the "library.libraries_directory_file_finder" service and do not need to search for the library at all? Depending on the amount of libraries, this indeed betters performance.

ALright, great! :)

Automatically closed - issue fixed for 2 weeks with no activity.