Fix test with Drupal 10.x

nevergone → changed the visibility of the branch 3377939-fix-test-with to hidden.

nevergone → changed the visibility of the branch 3377939-fix-test-with to active.

Between Sept 13th and Sept 20th 2023, two additional failures started occurring.

20 Sep 2023 at 22:43 EDT PHP 8.2 & MySQL 8, D10.1 27 pass, 7 fail →
13 Sep 2023 at 22:50 EDT PHP 8.2 & MySQL 8, D10.1 30 pass, 5 fail →

Likely relating to 3 commits pushed in on Sept 12th 2023.

@joseph.olstad

DrupalCI is deprecated, use Gitlab. The tests were wrong, but I fixed them.

vendor/bin/phpunit -c /var/www/web/core/phpunit.xml web/modules/custom/better_exposed_filters/tests/src/
PHPUnit 9.6.17 by Sebastian Bergmann and contributors.

Testing /var/www/web/modules/custom/better_exposed_filters/tests/src
.....................................                             37 / 37 (100%)

Time: 01:22.893, Memory: 12.00 MB

OK (37 tests, 280 assertions)

Remaining self deprecation notices (2)

  2x: Drupal\FunctionalJavascriptTests\JSWebAssert::assertExpectedAjaxRequest called unnecessarily in a test is deprecated in drupal:10.2.0 and will throw an exception in drupal:11.0.0. See https://www.drupal.org/node/3401201
    1x in BetterExposedFiltersTest::testAutoSubmit from Drupal\Tests\better_exposed_filters\FunctionalJavascript
    1x in BetterExposedFiltersTest::testAutoSubmitWithExposedFormBlock from Drupal\Tests\better_exposed_filters\FunctionalJavascript

I added a merge request.

If someone wanted to improve this:
https://git.drupalcode.org/issue/better_exposed_filters-3377939/-/pipeli...

Indeed, but this issue was just to make the tests work. It does not refactor, improve styling, or add new functionality.

ya , nice, thanks!

Thanks for fixing those!

Automatically closed - issue fixed for 2 weeks with no activity.