- Issue created by @joseph.olstad
- Issue was unassigned.
- 🇨🇦Canada optasy
I have a patch for this issue, this will set CkEditor 4 for the "Full HTML" format, kindly review.
- Status changed to Needs review
over 1 year ago 11:57pm 15 October 2023 - 🇨🇦Canada smulvih2 Canada 🍁
I think the idea behind the Full HTML text format is to allow advanced users to enter HTML without using CKEditor. That being said, we did discuss the possibility of just adding codemirror or similar to Full HTML to make the editing experience better.
- 🇨🇦Canada joseph.olstad
I thought the idea of Full HTML was to provide a ckeditor experience that has no content filtering enabled?
Generally for non-ckeditor experience I've seen new formats being added such as ones called "No wysiwyg" or "Sans wysiwyg" format.
- Status changed to Needs work
over 1 year ago 5:34pm 18 October 2023 - 🇨🇦Canada sylus
I have asked @smulvih2 to take a closer look at this and maybe see what core does and / or recommends.
Our initial thouht was with full html there should be no content filtering enabled etc. :)
- 🇨🇦Canada optasy
Thanks @smulvih2 and @joseph.olstad for your input, the patch that I provided has the content filtering options disabled for the "Full HTML" configuration, I'll have a close look and see what other plugins can be disabled.
- Status changed to Needs review
over 1 year ago 6:09pm 20 October 2023 - 🇨🇦Canada smulvih2 Canada 🍁
Patch in #5 adds
filter.format.full_html.yml
towxt_ext_editor
, but it already exists in wxt_core. wxt_core gets installed first so this config file in /config/optional would be ignored. Since we are enabling CKEditor with this text format, it would be best to move this config file over towxt_ext_editor
or elsewxt_core
will gain a bunch of dependencies. So just need to delete the existing config file in wxt_core. Also notice CKE4 is used for the editor, but we should probably cut over to CKE5 for this.Here is a patch that moves the text format from
wxt_core
towxt_ext_editor
, using CKE5. The only buttons I used was Source, Media, Linkit. With this patch in place, I now get CKE5 for full_html on install.I was able to copy/past some HTML from Canada.ca homepage and it worked without stripping anything. I was also able to update the images using the Media button, and change links using the Link button.
- 🇨🇦Canada sylus
I think we will have to do the same thing that we did for rich_text.
editor.editor.rich_text_ckeditor5.yml editor.editor.rich_text.yml filter.format.rich_text_ckeditor5.yml filter.format.rich_text.yml <code> So we will need to add <code> editor.editor.full_html_ckeditor5.yml editor.editor.full_html.yml filter.format.full_html_ckeditor5.yml filter.format.full_html.yml
And still have CKEditor 4 the default till we can confidently remove it.
- Status changed to Needs work
over 1 year ago 6:51pm 20 October 2023 -
sylus →
committed 9fad2237 on 5.0.x authored by
smulvih2 →
Issue #3377591 by smulvih2, OPTASY: [D10] - Fresh install defaults for...
-
sylus →
committed 9fad2237 on 5.0.x authored by
smulvih2 →
- Status changed to Fixed
over 1 year ago 5:33pm 21 October 2023 - 🇨🇦Canada sylus
Committed and attributed but I did make both filters and editors for both CKEditor 4/5.
Automatically closed - issue fixed for 2 weeks with no activity.