Captcha 8.x-1.11 release contains changes from 2.x

Created on 27 July 2023, over 1 year ago

Problem/Motivation

, wow, this was intentional, 8.x-1.11 release contains a lot of things from 2.x including some breaking changes, like πŸ› 8.x-1.12 shows captcha fieldset, even without captcha output Fixed

Steps to reproduce

See https://git.drupalcode.org/project/captcha/-/compare/8.x-1.10...8.x-1.11...

Proposed resolution

Revert all changes from 2.x and release 8.x-1.13

Remaining tasks

Provide a patch

User interface changes

Revert everything to 8.x-1.x

API changes

Revert everything to 8.x-1.x

Data model changes

Revert everything to 8.x-1.x

πŸ’¬ Support request
Status

Closed: outdated

Version

1.12

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine Taran2L Lviv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Taran2L
  • πŸ‡ΊπŸ‡¦Ukraine Taran2L Lviv
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Thanks @Taran2L, that was a decision made in ✨ Difficult migration from Drupal 9 to 10 Fixed by @japerry as long-time maintainer.
    Our initial 2.x goal was to separate these breaking changes into 2.x and keep 8.x-1.x alive, but due to the complaints about hard Drupal 10 upgrade, 2.x was used as basis for 8.x-1.11. I wasn't in the position to stop that from happening, and I am not.

    @Grevil and me invested a lot of time to fix many many issues in Captcha that hadn't been well-maintained for a while, see https://git.drupalcode.org/project/captcha/-/compare/8.x-1.9...2.x?from_...
    While we surely didn't do everything perfectly right, there were many many improvements and fixes.

    See the discussion in ✨ Difficult migration from Drupal 9 to 10 Fixed about these points. From my perspective, there are two ways now:
    a) Fix the remaining issues
    b) Restore the 8.x branch (which would also mean to revert database changes made in the last releases

    I think A would be the better way, and please note that the old 8.x-1.x branch wasn't D10 compatible due to Symfony changes. That was the intial reason for 2.x and ✨ Difficult migration from Drupal 9 to 10 Fixed complaints...

    So far, the story behind.

    I'd strongly suggest we as a community should focus on providing fixes / MRs for the issues, instead of further arguing about what happened and who's responsible...

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Changing this into a support request as this was a decision made in ✨ Difficult migration from Drupal 9 to 10 Fixed as written in #4.

  • πŸ‡ΊπŸ‡¦Ukraine Taran2L Lviv

    hi @Anybody, thanks for the links, but by easing upgrading to D10, the module has been changed in such way that now it might require an extra effort from every module user affected by the change. Not blaming anyone, just disagree with the chosen path forward, sorry

    I do not have a solution, as database revert will be required now, and it might be tricky to have a D10 compatibility at the same time. Personally. not breaking stuff outweighs upgrade path (as it is require attention and dev time anyhow). Just my 2 cents

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Yes, as written above, I agree, but wasn't a choice I made or I was in the position to deny.

    Are you fine with closing this and instead resolve the issues?

  • πŸ‡ΊπŸ‡¦Ukraine Taran2L Lviv

    @Anybody, I'm not is position to tell you what to do in such scenarios to be honest :)

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    I'm close to fixing πŸ› 8.x-1.12 shows captcha fieldset, even without captcha output Fixed with BC! Are there other major issues for you?

  • Status changed to Closed: outdated over 1 year ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    That issue is fixed now, so I'll close this one. Thanks @Taran2L

Production build 0.71.5 2024