8.x-1.12 shows captcha fieldset, even without captcha output

Hi @drupalfan2,

simple fix would be to go to admin/config/people/captcha and delete the texts from the two fields.
I agree it shouldn't be there by simply upgrading anyway.

If possible you should consider upgrading to the recommended 2.0.2 version, but take a backup before.

Mybe this works, but it should be solved in the code,
version 1.10 didn't have this problem either.

This seems to be a major bug:

I am using 2 languages (en, de).
It is NOT possible to remove the text from the 2 fields as mentioned above.

This seems to be a translation problem. Maybe it works when only Enlish is used (no other language active).

The following code in captcha.module must be rewritten:

function template_preprocess_captcha(&$variables, $hook, $info) {
  $variables['title'] = _captcha_get_title();
  $variables['description'] = _captcha_get_description();

  // Add an indicator, if the captcha widget is visible, to
  // account for _captcha_required_for_user().
  // See Captcha::preRenderProcess().
  // If the CAPTCHA was solved, hidden inputs have to be preserved to the form
  // but the CAPTCHA and its wrappers are not visible.
  // This variable exposed this to the theme layer transparently:
  $variables['is_visible'] = isset($variables['element']['captcha_widgets']);
  // Attach library:
  $variables['#attached']['library'][] = 'captcha/base';
}

Can you help?

@drupalfan2 I wasn't able to reproduce this. Did you remove the strings on the settings page AND the config translation tab?
I guess you missed one of them. Otherwise, could you provide screenshots of the forms, please?

I tried to remove the text, but it is NOT possible, this is a major bug.

It is wrong to display this text if reCaptcha v3 is used.

Please restore the behavior as it was in v1.10.
v1.10 did not make any problems, but v1.11 has multiple problem: Wrong text on wrong place. Unable to remove / empty the text field ...

If you do not want to help so please do not block others in helping in this issue.
Thank you.

It is not easy, but if I remove the description and the title (both empy), on all pages the fieldset still is visible (has border).

So still searching for a solution that behaves like in v1.10!

Yeah, indeed that wrapper shouldn't be there, if there's no content.

Yes, seeing that empty border. Not good. Have to downgrade.

More then 200.000 sites are using this module.

This is reaeon enough to set the priority of this issue to "major".

This is a completely unnecessary bug that should be fixed immediately.
See above for suggestions on how to fix it.

If you do not want to help so please do not block others in helping in this issue.

This is unnecessarily unfriendly in an open source project where I already invested several working days. Perhaps you should think about that for a while and ask yourself about your sponsoring here.
You didn't even provide a MR to fix things, but behave like this, shame on you.

Must be solved in 2.x-dev. I'll take a look (from my time = money). Not for you, but for the community.

Anybody → closed merge request !80

I implemented the suggestion from 📌 Use "legend" HTML element instead of label in 'captcha.html.twig', use div if no title given Fixed which should visually mitigate the issue.

@drupalfan2 can you tell if with older 8.x versions of captcha there was an empty div, when the reCaptcha was used, but not visible?

Okay, I took a look at the older 8.x versions and the captcha div was also present there, just invisible as it was a div.

So this should be fixed using the solution from 📌 Use "legend" HTML element instead of label in 'captcha.html.twig', use div if no title given Fixed . @drupalfan2 would you like to test the MR over there, please? I'll close this one here, as it's just the same. So I'll postpone this on 📌 Use "legend" HTML element instead of label in 'captcha.html.twig', use div if no title given Fixed and hope we can make it land *very* soon!

Screenshot from 8.x-1.10:

Anybody → closed merge request !81

Fixed in 📌 Use "legend" HTML element instead of label in 'captcha.html.twig', use div if no title given Fixed
Please try 2.x and ensure to empty the "Title" field, if you don't want the title to be shown. Hiding the title wasn't possible in old versions.

I added a follow-up to document the remaining breaking change for reCaptcha users: 🐛 reCaptcha shows CAPTCHA legend since CAPTCHA 8.x-1.11 / 2.x update Active

Thank you that you changed your mind and realized that this is a major issue and you came back to help.

I tested the patch
https://git.drupalcode.org/project/captcha/-/merge_requests/68.patch
with 8.x-1.11 and 8.x-1.12 ... works in both versions and solves the problem in this issue #3375511.

8.x.1.13 also works and not patch is needed anymore for 1.13.
Thank you very much.

Although we helped we did not get any issue credit.
You should be thankful instead of criticizing when you have been criticized. From the very beginning this was a major issue concerning hundred thousand of sites.

Thanks @drupalfan2. Unfortunately the same applies to you.

You didn't even provide a MR to fix things

Of course, you would have been credited, it you provided a helpful patch or MR. Of course I'm thankful for the screenshots and opening the issue, but that and #4 was helpful to document and find the issue, but not to fix it, sorry.

Automatically closed - issue fixed for 2 weeks with no activity.