- Issue created by @gillesbailleux
- πΊπΈUnited States DamienMcKenna NH, USA
I did a quick search on the tag and found https://stackoverflow.com/questions/27913739/how-are-open-graph-ogsee-al... and https://stackoverflow.com/questions/24157235/open-graph-ogsee-also-param..., both of which mention it should allow multiple values. However, I can't find any official documentation on it on either the OG site, Facebook's docs site, or Pinterest's site, so it may be deprecated. That said, let's make it allow multiple values because it seems like it was supposed to.
- π§πͺBelgium gillesbailleux La Roche-en-Ardenne
No doubt you can add up to 4 URLs; if needed, I currently add them via a twig file.
- π§πͺBelgium gillesbailleux La Roche-en-Ardenne
I did not see you renamed the issue, Damien. This is very kind of you, thank you very much.
- π§πͺBelgium gillesbailleux La Roche-en-Ardenne
Greetings,
Allowing multiple comma separated values to the
og:see_also
tag would be a nice feature for the upcoming metatag 2.x release.Thank you once again for this module.
- Status changed to Needs review
9 months ago 12:47pm 2 April 2024 - last update
9 months ago 120 pass - π©πͺGermany Anybody Porta Westfalica
@gillesbailleux would you mind testing this and provide some feedback to push things forward here?
The tests are green, so maybe this can be set RTBC if it works? The change is quite simple.
- last update
7 months ago 120 pass - last update
7 months ago 117 pass, 6 fail - π§πͺBelgium gillesbailleux La Roche-en-Ardenne
@Anybody: the patch has been successfully applied on two websites through two manners. It has been programmatically applied on a live site thanks to the help of Didier Misson β and manually applied by me on a test website.
Two comma separated values have been added to the "See also" field and the two values are in the source code.
Thank you very much and greetings from Belgium.
- Status changed to RTBC
7 months ago 8:26am 20 June 2024 - π©πͺGermany Anybody Porta Westfalica
Thank you very much for the quick reply @gillesbailleux so let's set this RTBC :)
- Status changed to Needs work
3 months ago 8:22pm 20 September 2024 - πΊπΈUnited States DamienMcKenna NH, USA
The patch needs to be turned into an MR against the 2.1.x branch.
- First commit to issue fork.
- Merge request !142Issue #3377205: Allow OG "See also" to have multiple values β (Merged) created by Grevil
- π©πͺGermany Grevil
Done! We should also change the default branch of metatag from "8.x-1.x" to "2.1.x".
- π©πͺGermany Anybody Porta Westfalica
Thanks! I'm setting this RTBC, but @damienmckenna should decide if this should have further tests with multiple values. I think that would make sense. But I'm not against merging as-is.
- π©πͺGermany Anybody Porta Westfalica
@gillesbailleux just saw that this still needs the description to be updated? Would you do that?
Issue summary says (TODO):
Write "URL to related content" in the description.
- π§πͺBelgium gillesbailleux La Roche-en-Ardenne
@anybody: sorry for my late answer. I am not sure to understand what I have to do.
- π©πͺGermany Grevil
Unsure about this. Other plugins like "OgLocaleAlternative" also support multiple values, but do not have any special description regarding the support of multiple values. I'd vote against that.
- πΊπΈUnited States DamienMcKenna NH, USA
Meta tags that allow multiple values will automatically have a note added to their description.
-
damienmckenna β
committed febde261 on 2.1.x authored by
grevil β
Issue #3377205 by damienmckenna, grevil, gillesbailleux, anybody: Allow...
-
damienmckenna β
committed febde261 on 2.1.x authored by
grevil β
Automatically closed - issue fixed for 2 weeks with no activity.