- Issue created by @Rohit Rana
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 5:20am 25 July 2023 - last update
over 1 year ago 6 pass - Status changed to Needs work
6 months ago 7:07am 31 May 2024 - 🇵🇭Philippines paraderojether
Hi
I reviewed patch #2, and there is 1 phpcs remaining.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_pager FILE: /Users/jetherparadero/Q2_DO/q2_issues/web/modules/contrib/entity_pager/src/EntityPager.php ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityInterface. ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- Time: 372ms; Memory: 12MB - last update
6 months ago 6 pass - Status changed to Needs review
6 months ago 7:21am 31 May 2024 - 🇵🇭Philippines paraderojether
I created MR to fix remaining issue, please review.
Thank you.
- Status changed to RTBC
6 months ago 8:18am 31 May 2024 - 🇮🇳India dev16.addweb
I have tested phpcs issue, Now all issue are resolved, moving to RTBC.
addweb@addweb-HP-ZBook-15-G2:~$ .config/composer/vendor/squizlabs/php_codesniffer/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css Drupal8-vagrant/web/web/contribution/d9_contribution2/web/modules/custom/entity_pager/ addweb@addweb-HP-ZBook-15-G2:~$