Remove check for 10200 update from help module

I think we can remove help topics module's remains within the same issue

Also when update hooks will get cut on next major, or it will need own own issue

Stumbled upon this. Issues for removing deprecated code should be a child of the relevant Meta issue to remove deprecated code from the upcoming major.

Added review, only this 2 places to fix but MR removing code instead of just version check

@andypost, thanks. I did this quickly without much thought or knowledge of the help and search system. I need to concentrate on other things for a while so hopefully someone can finish this.

quickly reverted and fixed, looks it can be backported to 10.3.x

No it should not be backported to 10.x because the hook is required to be executed before cache cleaning

The fix probably needs better comment about order of cache cleaning for plugins, somehow search is cleaned after help, probably because of alphabetic order

Historically the hook creating new database table for search indexing but table-exists-check is too expensive to use at runtime

This was posted in #needs-review-queue-initative so taking a look.

Maybe in the future we should drop a comment like //remove in drupal:11.0.0 so it gets picked up in greps.

But nice catch! Replacement seems fine

Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!

catch → closed merge request !8809

Automatically closed - issue fixed for 2 weeks with no activity.