Warning: window.reload() can do form submits

Open on Drupal.org →

Created on 21 July 2023, 11 months ago

Updated 18 March 2024, 3 months ago

This is not necessarily an issue with this module and the PageReloadCommand that it implements (thank you by the way!!!).

I just want to drop this note here incase someone is pulling out their hair like I just was.

It turns out the the JavaScript function that this module uses, window.reload(), will quietly do a form submit if the form submit was the last thing the browser window did before the reload() function was called.

So I think this module is doing the right thing, but folks should be careful if they are expecting to update form values in a modal, and then expecting the form to display the new values after responding with PageReloadCommand. In our case, with a multi page webform, the form was being resubmitted and replacing our modified values.

We ended up writing our own custom CleanPageReloadCommand that just does window.location.replace(window.location.pathname). I'm not suggesting this module needs to change. Just leaving this hear in case it helps someone else.

✨ Feature request

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States JonMcL Brooklyn, NY

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!2Warning: window.reload() can do form submits
Merged
🇩🇪Germany Anybody
updated 4 months ago

Comments & Activities

Issue created by @JonMcL
Comment 11 months ago →
🇪🇸Spain psf_ Huelva
Thx by the note :_ D

Please, could you extend this module with the new command and document it in the readme?
Status changed to Needs review 8 months ago1:03pm 27 October 2023
Comment 8 months ago →
🇩🇪Germany Anybody Porta Westfalica
@psf_ see https://stackoverflow.com/questions/570015/how-do-i-reload-a-page-withou...

if ( window.history.replaceState ) { window.history.replaceState( null, null, window.location.href ); } window.location = window.location.href;
Seems to be recommended, but also read the other comments.
Merge request !2Use window.location → (Merged) created by Anybody
Status changed to RTBC 4 months ago2:07pm 23 February 2024
Comment 4 months ago →
🇫🇷France mably
Works fine here, would be nice to have it merged and released. Thanks!
Status changed to Fixed 4 months ago2:04pm 4 March 2024
Comment 4 months ago →
🇪🇸Spain psf_ Huelva
Thx : )
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024