- Issue created by @chrisfromredfin
- 🇺🇸United States mherchel Gainesville, FL, US
Fixed, and also did a good amount of refactoring to simplify the CSS.
- Merge request !398Issue #3376203: Filter's checkbox labels look broken at smaller viewports → (Merged) created by mherchel
- Status changed to Needs review
over 1 year ago 7:07pm 21 July 2023 - last update
over 1 year ago Custom Commands Failed - Open on Drupal.org →Core: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - last update
over 1 year ago 80 pass - First commit to issue fork.
- last update
about 1 year ago 77 pass - 🇩🇪Germany marcoliver Neuss, NRW, Germany
I updated the MR against 1.0.x, since the styles were relocated from the Svelte component files into one global CSS file.
- 🇮🇳India divya.sejekan
The overlapping of the radio buttons is fixed verified in Drupalpod for Drupal 10 using MR!398. But in tablet the filters moves a bit when the accordion is expanded refer to the video attached.
Steps Followed:
1. Install drupal 10
2. Navigate to /admin/modules/browse , expand the filter option
3. Check in smaller resolutions.For the issue in tablet and Error in MR keeping this in Need review state since the MR has some error
- Status changed to Needs work
10 months ago 6:10am 23 February 2024 - 🇺🇸United States mherchel Gainesville, FL, US
@divya.sejekan great catch! However, I'm moving this to a followup, since this is a minor UX issue, and shouldn't block this core MVP issue.
Followup is at 🐛 Content shift when expanding filters accordion Active . I'm going to bring this back up to date, and set back to RTBC since no major changes.
- Open on Drupal.org →Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
10 months ago Not currently mergeable. - Status changed to RTBC
10 months ago 3:33pm 23 February 2024 - 🇺🇸United States mherchel Gainesville, FL, US
Brought back up to date and should be good to go!
- last update
10 months ago 86 pass - last update
10 months ago 86 pass -
chrisfromredfin →
committed 15d99e72 on 1.0.x authored by
mherchel →
Issue #3376203: Filter's checkbox labels look broken at smaller...
-
chrisfromredfin →
committed 15d99e72 on 1.0.x authored by
mherchel →
- Status changed to Fixed
10 months ago 6:26pm 24 February 2024 - 🇺🇸United States chrisfromredfin Portland, Maine
Tests passing, rebased, confirmed working in DrupalPod - I love it! Go gators.
- 🇮🇪Ireland lostcarpark
This change has introduced a StyleLint error in GitLabCI:
css/pb.css 678:3 ✖ Expected "margin-block-end" to come before "font-size" order/properties-order 1 problem (1 error, 0 warnings)
We haven't made it mandatory for code quality tests to pass in GitLabCI yet.
I will open a follow-up issue.
Automatically closed - issue fixed for 2 weeks with no activity.