Option to not redirect all requests if ForcedLogin paths value is empty

This adds a new setting that controls whether redirects should happen if the paths value is empty, with it defaulting to TRUE to match current settings.

facepalm.gif

The last submitted patch, 3: cas-n3375946-2.patch, failed testing. View results →

Forgot the ::submitForm() changes again. Also added a description explaining when it would be useful.

The last submitted patch, 5: cas-n3375946-5.patch, failed testing. View results →

I swear I've done this before X-)

This fixes the form field as it now looks for the correct variable.

The last submitted patch, 7: cas-n3375946-6.patch, failed testing. View results →

There was a bug in how this worked, it was verifying that $this->forcedLoginPaths was not empty, but it actually needed to make sure that $this->forcedLoginPaths['pages'] was not empty.

This should work now.

The last submitted patch, 10: cas-n3375946-10.patch, failed testing. View results →

Hopefully this will fix the last issue. (I now have the tests running locally, had previously forgotten to download cas_mock_server so the tests had been failing)

Converted to merge request/

I think this needs a post update hook to set the default value of the new config key.
Also, would be great to add a test.

If this is merged it would be good to add the new feature to the release notes and a scenario or two in which to use the setting.
How do we expect this to work, when the paths setting is negated?