JavaScript not properly clearing the data attributes, when multiple classes are set

I added both Kernel and JS tests, to show the incorrect behavior!

Input:

<a class="test1 test2 test3 test4" href="mailto:example@mail.com"></a>

Expected:

<a class="test1 test2 test3 test4" href="mailto:example@mail.com"></a>

Actual:

<a class="test1 data-spamspan-test2 data-spamspan-test3 data-spamspan-test4 spamspan" href="mailto:example@mail.com">example@mail.com</a>

@Grevil please also test other typical attributes, like id or rel for the a href.

At least add
id="test-id"
rel="noopener noreferrer"
please to all these tests, where it's not yet present.

Other attributes might be untypical for mailto: links, but should also work technically. I don't think we have to test them.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a?retiredLocal...

Yea this isn't working yet, really annoying, working on these strings instead of using a proper Crawler class

@Grevil please also test other typical attributes, like id or rel for the a href.

At least add
id="test-id"
rel="noopener noreferrer"
please to all these tests, where it's not yet present.

Other attributes might be untypical for mailto: links, but should also work technically. I don't think we have to test them.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a?retiredLocal...

The reason is the too simple split by a space. Attributes must be extracted more safely. We don't even have to touch their values :)
Input:
<a class="test1 test2 test3 test4" href="mailto:example@mail.com"></a>

Expected (PHP Filter):
<a class="spamspan" data-class="test1 test2 test3 test4" href="mailto:example@mail.com"></a>

Actual (PHP Filter):
<a class="spamspan" data-spamspan-class="test1 data-test2 data-test3 data-test4" href="mailto:example@mail.com"></a>

Expected (JS / Finally):
<a class="test1 test2 test3 test4" href="mailto:example@mail.com"></a>

Actual (JS / Finally):
<a class="test1 data-spamspan-test2 data-spamspan-test3 data-spamspan-test4 spamspan" href="mailto:example@mail.com">example@mail.com</a>

As discussed, we should revert the explode changes and convert the attributes to "data-spamspan" attributes in processAsDom, using the DOMDocument / DOMElement classes, before running "replaceMailtoLinks".

And also add the other mentioned tests.

Alright, all done, please review!

Left a couple of minor comments on the MR.

Coded this together with @Grevil and was harder than we thought due to the #%$&&$§ Iterator on Dom nodes... I hope it's all fine now. And surely a lot better than using regex or explode. See https://blog.codinghorror.com/parsing-html-the-cthulhu-way/

Hopefully this part is DONE now :)

Thanks for the super fast review @joevagyok! :)

For the last steps @Grevil :)

Good job there!

Reworked "disableAttributes()" based on the comments provided, thanks for the review! Adding the remaining tests mentioned in #6 and #7.

Alright, added some final tests for this!

Also found out, that the parameters given to assertSame() were in the wrong order (actual was expected, expected was actual).

Final review pls!

PR approved!

Merged, thanks for the work on this!

Automatically closed - issue fixed for 2 weeks with no activity.