- Issue created by @sonam_sharma
- Status changed to Needs work
over 1 year ago 1:40pm 18 July 2023 - 🇵🇭Philippines kenyoOwen
Hi sonam_sharma
When I applied your patch it gives me this error
Checking patch README.md...
Checking patch access_token_auth.links.menu.yml...
error: while searching for:
description: 'Configuration options for the Access Token Auth module.'
parent: system.admin_config_services
route_name: access_token_auth.settings
weight: 15
error: patch failed: access_token_auth.links.menu.yml:3
error: access_token_auth.links.menu.yml: patch does not apply
Checking patch src/TokenManagerInterface.php...
error: while searching for:
/**
* Get a valid token from a specific user.
*
* @param string $user_id
* The user ID to get valid tokens from.
*
* @return \Drupal\access_token_auth\Model\Token|nullerror: patch failed: src/TokenManagerInterface.php:53
error: src/TokenManagerInterface.php: patch does not apply - Status changed to Needs review
over 1 year ago 6:19am 19 July 2023 - 🇮🇳India Ashutosh Ahirwal India
Providing updated patch with fixes and updating issue summary according to the result of phpcs command for 1.x branch.
Please review. - First commit to issue fork.
- @frederikvho opened merge request.
- 🇧🇪Belgium Frederikvho Belgium
Hi,
I still encountered plenty of whitespace errors while applying the patch, so I ran it again using the --whitespace=fix option.
I have created an issue fork and opened a merge request.The issue should be fixed now. Please review the merge request.
Thanks!
- 🇨🇷Costa Rica robert-arias
Thank you everyone for participating so actively and trying to contribute! Unfortunately, the reported phpdocs issues are outdated. As for the other fixes regarding the README: markdown files should be excluded from phpdocs checks, so the patches and MR aren't of much value, thought I appreciate the checks.
For future reference, this module uses Drupal's phpdocs coding standards.
- Status changed to Closed: outdated
over 1 year ago 3:51am 20 July 2023 - 🇧🇪Belgium Frederikvho Belgium
Hi,
It was actually the applying process of the patches that resulted in whitespace errors and not the running of a code sniffer.
Nevertheless, you are saying that these fixes to the documentation had already been taken care of in another issue? Just double checking.
Kind regards