- Issue created by @ressa
- 🇩🇰Denmark ressa Copenhagen
I created Multiple layers in Leaflet → in the new documentation.
Could http://drupal.org/node/1645460 on the project page get the link title "Drupal 7 documentation" and a new link was added, to the new Drupal 10 documentation?
Resources
- Read license <<< Remove this one?
- Drupal 7 documentation
- Drupal 10 documentation →
- 🇩🇰Denmark ressa Copenhagen
You're welcome @Orkut Murat Yılmaz :) Feel free to add documentation to the Drupal 10 documentation system → , either one of the items on the list, or something else you think could be useful.
- 🇹🇷Turkey orkut murat yılmaz Istanbul
@ressa, thanks for your suggestion too. Can you review this issue ✨ Usecase or description available? Needs review ? I'd like to link it to this documentation, if it is okay too.
I'd be glad to go with your checklist as well and I hope that I can complete one of them this week.
- 🇩🇰Denmark ressa Copenhagen
Thanks for documenting the Leaflet Layers module @Orkut Murat Yılmaz. I agree, it would a great addition to the Leaflet documentation. I added it as an item in the list in the Issue Summary, and created the page Add multiple Leaflet layers with Leaflet Layers module → , ready to be filled out, if you have time at some point?
- 🇹🇷Turkey orkut murat yılmaz Istanbul
@ressa, thanks for letting me do that. It's a great pleasure for me. Can you review the changes on that document too?
- 🇩🇰Denmark ressa Copenhagen
It looks great, thanks for adding content to the "Add multiple Leaflet layers with Leaflet Layers module" page @Orkut Murat Yılmaz.
- 🇮🇹Italy itamair
Hi here! Glad to announce that new Leaflet 10.2.5 release → added support (with this commit) for Vector Tiles sources usable by MapLibre GL Leaflet & Js (https://github.com/maplibre/maplibre-gl-leaflet).
It will be sufficient to add the
'type' => 'vector'
property in the specific overlay definition
and define an 'urlTemplate' property that accomplishes the correct reference (i.e.: https://docs.stadiamaps.com/tutorials/vector-tiles-with-leaflet/)
so to have all the advantages of Maplibre Vector Tiles (https://maplibre.org/maplibre-gl-js/docs/examples/vector-source/) over the Raster ones.I don't have time to write / add documentation for this, but may be some of you here can wrap up my report here and add proper documentation to the new Leaflet 10 documentation →
Thanks!
- 🇩🇰Denmark ressa Copenhagen
Thanks for adding support for Vector Tiles! It's the first time I hear about the concept, but it certainly works well, with fast loading and smoother zoom-experience. I found this Raster vs Vector Map Tiles article, which explains it well.
To try it out, I added it to my project https://arst.dk/kort as the fourth base layer (Stamen TonerLite Vector). It seems to take a few seconds to load, maybe because the leaflet/maplibre-gl-leaflet library needs to be downloaded from unpkg.com? Is it possible to embed the script directly in your Drupal 10 installation, or maybe it will eventually be included directly in the Leaflet module? ("... eventually add MapLibre GL Leaflet library")
Anyway, I am adding documenting this great new feature to the list, thanks again @itamair!
- 🇹🇷Turkey orkut murat yılmaz Istanbul
it's a huge leap forward! thanks for adding the MapLibre support:)
- 🇮🇹Italy itamair
@ressa ... woooow, your https://arst.dk/kort looks super cool!
Pretty impressed it could be done with (our) Drupal Leaflet module ... (it would be great to showcase it in the Leaflet project page also, along my demo ... ).Sincerely your "Stamen TonerLite Vector" looks pretty fast ... same as the first three.
So referencing the maplibre-gl-js and maplibre-gl-leaflet libraries from doesn't look a clear issue to me.Your consideration brings me the occasion to share my concerns, as I was even minding about:
option 1: the possibility to rather move out of the module all the other libraries embedded into it now (such leaflet itself, and fullscreen, geoman, etc. But I remember that it was causing some issues when Leaflet map should show up all sudden , may be with lazy loading or when located into some field group or accordion etc ...
option 2: embed also the maplibre-gl-js and maplibre-gl-leaflet libraries into the Leaflet module, along with all the others, for sure would make the being required and load the fastest ...
@ressa, @orkut which of the 2 above options would be better for you and for the Leaflet module in general? 1 or 2?
- 🇹🇷Turkey orkut murat yılmaz Istanbul
@itamair, thanks for asking. For my perspective, option 2 would be better, but I can't be sure about other users/developers mileage.
@ressa, thanks for documentation task list update and your example too:)
- 🇹🇷Turkey orkut murat yılmaz Istanbul
I've decided to complete some of these documentation tasks and I'll share the updates ASAP.
- 🇮🇹Italy itamair
thanks @Orkut Murat Yılmaz and @ressa ...
Drupal Leaflet module maintenance and evolution is one of the tasks I am most committed in my life at the moment (I love Geomapping with Leaflet and implementing cool things also with it in Drupal even more), so I am quite happy to spend the required time (for free) on it, and for the community as a whole.But if you both could assist on the proper Leaflet module documentation (that I cannot really cope appropriately ... ), and exactly the way you are doing, well I feel everything here could be even more cool and solid.
Thanks! - 🇩🇰Denmark ressa Copenhagen
Thanks @itamair, I am glad to hear you think it looks good :) Also know that I am very grateful for your work on Leaflet, and equally important the very thorough and competent answers and solutions you provided me. Both for getting choropleth's to work in ✨ How to create an Interactive Choropleth Map Fixed , but also more importantly, full Solr support for Leaflet in 🐛 Add Geometries support for Search API Solr and Views integration Fixed . Without that, it would have been impossible for me to build in Drupal 10. I would be honored, if it was used as a showcase.
I agree with @Orkut Murat Yılmaz that Option 2, to include the libraries in the Leaflet module would be better, to keep it simple, and avoid strange issues. Experts who need other versions are able to override it, via a custom module, but for most users the default versions are fine. Also, in terms of kB-size, the libraries are quite small (
maplibre-gl-leaflet
for example at ~10 kB) so not a problem. Having the libraries included in Leaflet, we can also be sure that everything works.Thanks for taking on documenting those features @Orkut Murat Yılmaz. I look forward to trying them, so please let us know here, when they are ready for a test drive :)
And yes I agree @itamair, let's each focus on what we can bring to the table, in terms of what best moves Leaflet forward, whether it is developing, documenting, or something else.
PS. I'll do some more testing of "Stamen TonerLite Vector" and see if I can understand the slight delay in rendering, but that's not important right now.
- 🇮🇹Italy itamair
Thus agreed guys! I am going to embed the maplibre-gl-js and maplibre-gl-leaflet libraries in the Leaflet modules itself, in the next incoming release.
And ok ... @ressa I will update both the Leaflet and the Geofield (itself) project pages to include a link to your cool https://arst.dk/kort, as advanced demo / showcase of the drupal geofield stack ...
Just let's stay tuned on this issue.
- 🇩🇰Denmark ressa Copenhagen
Sounds great! In another Leaflet project, I have created 📌 [Meta] Release version 2.2 Active , to help keep the momentum there as well.
Speaking of pushing issues forward, I left a comment ✨ Provide options to sanitize filenames (transliterate, lowercase, replace whitespace, etc) Fixed the other day, praising the Needs Review Queue Initiative → by @smustgrave, which really helps keep Drupal core issues moving. It seems to be aimed at Drupal core issues ... I am not sure if contrib module issues could get included as well? It could be worth considering.
- 🇩🇰Denmark ressa Copenhagen
I just discovered the amazing proximity search feature which is built into Geofield → , which made me realize that it could similarly use some improvements with its documentation, so I created an issue.