Contrib.social

[D10] / [D9] WxT 4 & 5 - Remove IE8 from the wxt build, IE8 cleanup

Open on Drupal.org →
Created on 12 July 2023, over 1 year ago
Updated 27 July 2023, over 1 year ago

Problem/Motivation

Bumping this to critical, this is a pretty major bug fix for modern browsers and optimizes our payload.

Affects 5.0.x and also 4.5.x
I've created a new module wxt_chart_stability to resolve a ckeditor nbsp bug that prevents wetboew charts from functioning correctly, now the first of multiple charts renders
see the chart library :

Now on the second chart rendering I'm seeing an internet explorer 8 javascript exception.

Uncaught TypeError: Cannot read properties of undefined (reading 'slicelegend')
    at createCharts (ie8-wet-boew2.js?rxmtyn:2817:26)
    at HTMLTableElement.<anonymous> (ie8-wet-boew2.js?rxmtyn:3849:4)

Which leads me to suggest that we need to clean up ie8 js and css and eradicate it from our builds since ie8 is basically no longer supported by anyone, remove references to it and prevent loading unique ie8 javascript. It must be removed because modern browsers are so far ahead that they've stopped conditionally loading javascript based on browsername/version comparisons and end up loading javascript that they should not be loading. We do not want ie8 javascript loaded at all.

Steps to reproduce

Follow the instructions on the wxt_chart_stability module page, install this module, see screenshots.

Once you've installed this module that works around a nbsp feature/bug in ckeditor then insert this markup,
the rendered page will crash on the ie8 js exception, the second chart will not render.

<section>
<h2>Area charts</h2>

<p>&amp;lt;table class=&quot;wb-charts wb-charts-area table&quot;&amp;gt;</p>

<table class="wb-charts wb-charts-area table">
	<caption>Number of pages by main purpose and audience</caption>
	<tbody>
		<tr>
			<td>&nbsp;</td>
			<th>Education</th>
			<th>Task</th>
			<th>Navigation</th>
			<th>Support</th>
			<th>Information</th>
			<th>Corporate</th>
		</tr>
		<tr>
			<th>General</th>
			<td>2</td>
			<td>0</td>
			<td>20</td>
			<td>4</td>
			<td>100</td>
			<td>50</td>
		</tr>
		<tr>
			<th>Students</th>
			<td>2</td>
			<td>2</td>
			<td>1</td>
			<td>5</td>
			<td>50</td>
			<td>0</td>
		</tr>
		<tr>
			<th>Business</th>
			<td>60</td>
			<td>10</td>
			<td>20</td>
			<td>90</td>
			<td>50</td>
			<td>8</td>
		</tr>
		<tr>
			<th>Professional</th>
			<td>46</td>
			<td>26</td>
			<td>5</td>
			<td>101</td>
			<td>200</td>
			<td>142</td>
		</tr>
		<tr>
			<th>Lawyer</th>
			<td>0</td>
			<td>2</td>
			<td>4</td>
			<td>0</td>
			<td>300</td>
			<td>300</td>
		</tr>
	</tbody>
</table>
</section>

<section>
<h2>Bar charts</h2>

<p>&amp;lt;table class=&quot;wb-charts wb-charts-bar table&quot;&amp;gt;</p>

<table class="wb-charts wb-charts-bar table">
	<caption>Number of pages by main purpose and audience</caption>
	<tbody>
		<tr>
			<td>&nbsp;</td>
			<th>Education</th>
			<th>Task</th>
			<th>Navigation</th>
			<th>Support</th>
			<th>Information</th>
			<th>Corporate</th>
		</tr>
		<tr>
			<th>General</th>
			<td>2</td>
			<td>0</td>
			<td>20</td>
			<td>4</td>
			<td>100</td>
			<td>50</td>
		</tr>
		<tr>
			<th>Students</th>
			<td>2</td>
			<td>2</td>
			<td>1</td>
			<td>5</td>
			<td>50</td>
			<td>0</td>
		</tr>
		<tr>
			<th>Business</th>
			<td>60</td>
			<td>10</td>
			<td>20</td>
			<td>90</td>
			<td>50</td>
			<td>8</td>
		</tr>
		<tr>
			<th>Professional</th>
			<td>46</td>
			<td>26</td>
			<td>5</td>
			<td>101</td>
			<td>200</td>
			<td>142</td>
		</tr>
		<tr>
			<th>Lawyer</th>
			<td>0</td>
			<td>2</td>
			<td>4</td>
			<td>0</td>
			<td>300</td>
			<td>300</td>
		</tr>
	</tbody>
</table>
</section>

Proposed resolution

Stop loading the ie8-wet-boew2.js library as IE8 has next to zero penetration in the wild and has been abandoned by Microsoft in all options of their support packages.

Remaining tasks

See patch, this patch fixes the glitches.

User interface changes

TBD

API changes

TBD

Data model changes

TBD

🐛 Bug report
Status

Fixed

Version

5.0

Component

WxT Library

Created by

🇨🇦Canada joseph.olstad

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024