"Correct faulty and chopped off HTML" filter breaks JSON with

Created on 11 July 2023, about 1 year ago

Updated 12 July 2023, about 1 year ago

Problem/Motivation

For a block containing Shopify Buy Buttons (JavaScript) with only "Correct faulty and chopped off HTML" filter enabled (and limited to administrators) the filter removed the closing HTML elements from the JSON code:

[...]
"templates": {
  "title": `<div class="h3">Title {{data.title}}</div>`,
  "price": `<div class="h2">Hello world {{data.selectedVariant.price}}</div>`,
},
[...]

was filtered into:

[...]
"templates": {
  "title": `<div class="h3">Title {{data.title}}`,
  "price": `<div class="h2">Hello world {{data.selectedVariant.price}}`,
},
[...]

https://github.com/Shopify/buy-button-js/issues/806

The expected and correct result would be to keep the closing brackets from the JavaScript. Removing them breaks the code here.
Not sure if this edge-case is relevant, but I thought it would make sense to let you know. Especially because the reason isn't simple to find.

This might be an upstream issue with the library used to clean the HTML?

Steps to reproduce

See above.

Proposed resolution

Do not correct HTML within JSON or code withing

tags at all?

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

Filter →

Last updated 2 days ago

No maintainer

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Anybody
Comment about 1 year ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Isn't the solution here to not use that filter for this content
Comment about 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
@larowlan: Yes, that's why I set it Minor, BUT there are downsides, so I'd still consider this a bug:

You're forced to introduce a new input format only for this case, which might be bad UX

The filter is called "Correct faulty and chopped off HTML", but the HTML is not faulty and not chopped off, so it *should* work.

🐛 \Drupal\filter\Plugin\Filter\FilterHtmlCorrector and Html::normalize() and incorrectly "corrects" tags Needs work shows that there are other issues and I think cases that the filter doesn't handle perfectly.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024