- Issue created by @sidharth_soman
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:17am 11 July 2023 - 🇮🇳India sidharth_soman Bangalore
I have implemented the DI. Please review.
- Status changed to Needs work
almost 2 years ago 6:41am 13 July 2023 - 🇵🇭Philippines kenyoOwen
Hi sidharth_soman
I applied your patch and it removes the dependency injection issue, but it adds an error. please see the screenshots attached.
Thank you.
- Status changed to Needs review
almost 2 years ago 7:08am 13 July 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #2 by addressing #3, please review it.
Thanks & Regards,
Mrinalini - 🇮🇳India sidharth_soman Bangalore
@kenyoOwen, @mrinalini9 - This issue is created solely for the implementation of the DI and its required testing. A separate ticket needs to be created for addressing the PHPCS issues once this is merged. There's no requirement to fix the 'line exceeds 80 characters' and other such issues here.
- da9d7e32 committed on 2.0.x
add injection dependance & fix coding standard #3373848 - refs #3373848
- da9d7e32 committed on 2.0.x
- 🇫🇷France Nicolas S. Lyon, France
A new tag is available with injection dependancies.