- Issue created by @Grevil
- last update
over 1 year ago 3 pass - @grevil opened merge request.
- last update
over 1 year ago 3 pass - 🇩🇪Germany Grevil
Works great! A few core filters also have the weight set to "-10", so making it even lower could make sense?
Please review!
- Status changed to Needs review
over 1 year ago 10:08am 11 July 2023 - 🇩🇪Germany Anybody Porta Westfalica
I'm wondering about the README description a bit, as I would have expected the SpamSpan filter to run AFTER "Convert URLs into links" because I thought that filter may also transform email addresses into clickable email addresses.
Could you please test that without having the spamspan filter enabled? Just to be sure what that core filter does and if it only handles URLs?
If it doesn't touch email addresses, I think this is fine! If core uses -10, should we use -11 then to always put it on top?
BTW other modules validate the order to ensure the filtering works as expected, we could add that as minor feature request. Not sure which module does that, I think it's even in a core filter. You may try to drag the filters into crazy order to get the message...
- Status changed to Needs work
over 1 year ago 10:28am 11 July 2023 - 🇩🇪Germany Grevil
"Convert URLs into links" Does actually convert a simple mail adress like "aaa@bbb.com" into a mailto link
<a href="mailto:aaa@bbb.com">aaa@bbb.com</a>
!!So I guess you are right, and the README is wrong? Really weird...
- 🇩🇪Germany Grevil
Should I also check the "Convert line breaks into HTML" filter?
- 🇩🇪Germany Anybody Porta Westfalica
"Convert URLs into links" Does actually convert a simple mail adress like "aaa@bbb.com" into a mailto link aaa@bbb.com!!
So I guess you are right, and the README is wrong? Really weird...
Nice, good to know, so we should always put SpamSpan behind that filters weight and correct the README here.
Should I also check the "Convert line breaks into HTML" filter?
No, SpamSpan should be able to work before and after it. I'd tend to remove that from the README, as it's just confusing. For performance reasons it might be a good idea to place it before that one by default, but if the weights are in conflicts with the paragraph above, ignore that.
- last update
over 1 year ago 3 pass - last update
over 1 year ago 3 pass - Status changed to Needs review
over 1 year ago 2:51pm 11 July 2023 - last update
over 1 year ago 6 pass, 2 fail - last update
over 1 year ago 6 pass, 2 fail - Status changed to Fixed
over 1 year ago 2:57pm 11 July 2023 - 🇧🇪Belgium joevagyok
We should emphasize that, in the README, the Spamspan filter should be always configured to run as last.
- 🇩🇪Germany Grevil
We could also still initiate the formatter with a very low weight, using the doctrine annotation provided in the class.
- Status changed to Needs work
over 1 year ago 2:54pm 14 July 2023 - 🇩🇪Germany Anybody Porta Westfalica
- Assigned to joevagyok
- Issue was unassigned.