[8.x-2.x] Webform Summation Field

Thank you for applying! Reviewers will review the project files, describing what needs to be changed.

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

To reviewers: Please read How to review security advisory coverage applications → , What to cover in an application review → , and Drupal.org security advisory coverage application workflow → .

While this application is open, only the user who opened the application can make commits to the project used for the application.

Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.

1. FILE: webform_summation_field.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

2. Replace README.txt with README.md

Please take a moment to make your README.md follow the guidelines.

3. 8.x-1.1 is a wrong branch name, as branch names end with the literal .x. That branch needs to be removed.

Hi vishal.kadam,
I updated your suggestion to 3.0.1.
Pls help us check again.

Rest looks fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

This is a Li Qing's application. It means only Li Qing can do commits in the branch used for the application, and only him can change the status to Needs review. Other project maintainers are not involved in this application, since this application is for the user who applied, not for the used project.

No change has been done in the 8.x-2.x branch. Only Li Qing can do commits to change files as per review.

Hi Apademo, thanks for your reiew.

I'm the author of this module, sorry that I was quite busy when recived the feedback from vishal.kadam, Simbaw work with me in the same team, so he helped me to update the changes.

Do we need to do anything else on our end to continue the process?

@Li Qing, I have reviewed the changes, and they look fine to me.

Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.

I am changing priority as per Issue priorities.

No issues found
Changing status to RTBC!

• What follows is a quick review of the project; it doesn't mean to be complete
• For each point, the review usually shows some lines that should be fixed (except in the case the point is about the full content of a file); it doesn't show all the lines that need to be changed for the same reason
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance

Since the README.txt file has been committed, it should say more than Webform Summation Field.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.