- Issue created by @urvashi_vora
- Status changed to Needs work
about 1 year ago 6:52am 25 October 2023 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Provided patch apply cleanly but still throwing some remaining errors.
Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/summary_onlyRemaining issues.
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/summary_only/src/Plugin/Field/FieldFormatter/TextSummaryOnlyFormatter.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
85 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------Time: 92ms; Memory: 10MB
- ๐ฎ๐ณIndia Gautam_105@
Gautam_105@ โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 1 year ago 9:58am 25 October 2023 - ๐ฎ๐ณIndia Gautam_105@
@Ashutosh Ahirwal , @manishsaharan
i have fixed the issue and created MR for the same . Review the changes and se screenshot as well . - ๐ต๐ญPhilippines clarkssquared
Hi Gautam_105@
I applied your MR !1 and I confirmed that it fixes all the PHPCS erros, however, I will retain the status to needs review so that others can thoroughly check your MR. RTBC +1 for me.
โ summary_only git:(1.0.x) curl https://git.drupalcode.org/project/summary_only/-/merge_requests/1.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3359 0 3359 0 0 5772 0 --:--:-- --:--:-- --:--:-- 5841 Checking patch src/Plugin/Field/FieldFormatter/TextSummaryOnlyFormatter.php... Applied patch src/Plugin/Field/FieldFormatter/TextSummaryOnlyFormatter.php cleanly. โ summary_only git:(1.0.x) โ .. โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml summary_only โ contrib git:(master) โ
- First commit to issue fork.
-
manishsaharan โ
committed 2166b23d on 1.0.x authored by
Gautam_105@ โ
Issue #3373778 by urvashi_vora: Fix the issues reported by phpcs
-
manishsaharan โ
committed 2166b23d on 1.0.x authored by
Gautam_105@ โ
- Status changed to Fixed
10 months ago 10:51am 24 January 2024 - ๐ฎ๐ณIndia manishsaharan New Delhi
This is working fine, so marking the status to be fixed.
Thanks! Automatically closed - issue fixed for 2 weeks with no activity.