- Issue created by @urvashi_vora
- Status changed to Needs work
about 1 year ago 6:56am 30 October 2023 - 🇮🇳India ashutosh ahirwal India
Provided patch get applied cleanly but there are still some remaining issue found.
Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/slack_webform_handlerRemaining issues
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/slack_webform_handler/src/Plugin/WebformHandler/SlackWebformHandler.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Url.
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------Time: 217ms; Memory: 10MB
- Status changed to Needs review
about 1 year ago 6:58am 30 October 2023 - First commit to issue fork.
- @sarwan_verma opened merge request.
- Status changed to RTBC
about 1 year ago 7:28am 30 October 2023 - 🇮🇳India sarwan_verma
Hi @urvashi_vora,
patch #3 applied successfully and also created MR.
++RTBC . -
omar_emailat →
committed e70612b4 on 1.0.x
Issue #3373752 by ashutosh ahirwal: Fix the issues reported by phpcs
-
omar_emailat →
committed e70612b4 on 1.0.x
Automatically closed - issue fixed for 2 weeks with no activity.