Minor phpcs issues

Created on 10 July 2023, almost 2 years ago

Problem/Motivation

PHPCS comes up with a few errors in a single file - StageFileProxySubscriber.php

FILE: C:\xampp\htdocs\backendassignment\web\modules\custom\stage_file_proxy\src\EventSubscriber\StageFileProxySubscriber.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
15 | WARNING | [x] Unused use statement
86 | ERROR | [ ] Type hint "\Symfony\Component\HttpKernel\Event\ResponseEvent" missing for $event
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Run the phpcs command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig stage_file_proxy

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Closed: won't fix

Version

2.0

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.

Coding standards
It involves compliance with, or the content of coding standards. Requires broad community agreement.

Comments & Activities

Issue created by @sidharth_soman
Issue was unassigned.
Status changed to Needs review almost 2 years ago12:46pm 10 July 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 5.7
last update almost 2 years ago
1 pass, 2 fail
Comment almost 2 years ago →
🇮🇳India sidharth_soman Bangalore
Comment almost 2 years ago →
System Message
The last submitted patch, 2: 3373604-2.patch, failed testing. View results →
Status changed to Closed: won't fix almost 2 years ago1:01pm 10 July 2023
Comment almost 2 years ago →
🇺🇸United States smustgrave
Thanks for the interest but this was fixed in the main supported branch. And I don’t typically give credit for such tickets as they are just credit farming techniques. If you wish to get involved in this module or in Drupal please work on actual issues in the queue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024