Fix the issues reported by phpcs

C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig time_picker FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\css\time_picker.css ------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\src\Plugin\Field\FieldFormatter\TimePickerFormatter.php ------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\src\Plugin\Field\FieldFormatter\TimeRangePickerFormatter.php ------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\src\Plugin\Field\FieldType\TimePickerType.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\src\Plugin\Field\FieldType\TimeRangePickerType.php -------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" -------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\src\Plugin\Field\FieldWidget\TimePickerWidget.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 67 | ERROR | [x] Use null coalesce operator instead of ternary operator. 86 | ERROR | [ ] The array declaration extends to column 179 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------ FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\src\Plugin\Field\FieldWidget\TimeRangePickerWidget.php ------------------------------------------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 4 LINES ------------------------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 69 | ERROR | [x] Use null coalesce operator instead of ternary operator. 70 | ERROR | [x] Use null coalesce operator instead of ternary operator. 101 | ERROR | [ ] The array declaration extends to column 185 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\time_picker\time_picker.module ------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------ Time: 2.17 secs; Memory: 10MB

Comments & Activities

Issue created by @sidharth_soman
Issue was unassigned.
Status changed to Needs review over 1 year ago1:28pm 7 July 2023
Comment over 1 year ago →
🇮🇳India sidharth_soman Bangalore
All issues fixed. Please review the patch.
First commit to issue fork.
@frederikvho opened merge request.
Comment over 1 year ago →
🇧🇪Belgium Frederikvho Belgium
Hi,

I applied the patch from #2 and ran PHPCS again but it threw 2 remaining errors. I fixed them using PHPCBF and pushed all of it to a fork.
Please see merge request !2 for the latest fixes.

Kind regards,
Frederik
Status changed to RTBC 4 months ago6:32am 19 July 2024

Comment 4 months ago →

a.aaronjake

Hi @everyone,

@Frederikvho's changes on MR !2, can be applied successfully and confirmed it fixed the errors reported.

time_picker git:(675bac9) curl https://git.drupalcode.org/project/time_picker/-/merge_requests/2.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3716    0  3716    0     0   8485      0 --:--:-- --:--:-- --:--:--  8682
patching file src/Plugin/Field/FieldWidget/TimePickerWidget.php
patching file src/Plugin/Field/FieldWidget/TimeRangePickerWidget.php
patching file time_picker.module
➜  time_picker git:(675bac9) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig time_picker
➜  contrib git:(master) ✗

Will now move this to RTBC

Thanks,
Jake

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities