- Issue created by @urvashi_vora
- Status changed to RTBC
9 months ago 7:28am 29 September 2023 - 🇮🇳India Ashutosh Ahirwal India
I have reviewed the provided patch, It get applied cleanly.
Moving to RTBC.
FILE: /var/www/html/vb/d_cont/twig_events/src/Event/TwigRenderTemplateEvent.php
--------------------------------------------------------------------------------
FOUND 18 ERRORS AFFECTING 17 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Missing class doc comment
9 | ERROR | [ ] Class property $template_file should use lowerCamel naming
| | without underscores
9 | ERROR | [ ] Missing member variable doc comment
11 | ERROR | [ ] Missing member variable doc comment
13 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [x] Missing function doc comment
21 | ERROR | [ ] Missing short description in doc comment
22 | ERROR | [ ] Description for the @return value is missing
28 | ERROR | [ ] Missing short description in doc comment
29 | ERROR | [ ] Missing parameter comment
35 | ERROR | [ ] Missing short description in doc comment
36 | ERROR | [ ] Description for the @return value is missing
42 | ERROR | [ ] Missing short description in doc comment
43 | ERROR | [ ] Missing parameter comment
49 | ERROR | [ ] Missing short description in doc comment
50 | ERROR | [ ] Description for the @return value is missing
56 | ERROR | [ ] Missing short description in doc comment
57 | ERROR | [ ] Missing parameter comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /var/www/html/vb/d_cont/twig_events/twig_events.module
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 60ms; Memory: 8MB
Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig twig_events/
Patch review
1.0
Code
It involves compliance with, or the content of coding standards. Requires broad community agreement.
I have reviewed the provided patch, It get applied cleanly.
Moving to RTBC.