Many HTML tags add horizontal space or a line break between them when rendered.
PlainTextOutput::renderFromHtml() simply removes HTML tags but does not add spaces, which can lead to a result that is surprising for users.
Call PlainTextOutput::renderFromHtml('<p>Foo</p><p>Bar</p>'); .
The result will be FooBar but it would make more sense to have Foo Bar.
We noticed this when using HTML fields as metatag tokens. Some sentences are joined together without a space between them.
The method could add a space between each tag before stripping the tags.
Needs work
11.0 🔥
Last updated
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
I have tested the MR with this code snippet.
print_r(\Drupal\Component\Render\PlainTextOutput::renderFromHtml('<div class="test">Some content</div><p>Foo</p><p>Bar</p>'));
It results