Fix the warnings/errors reported by PHP_CodeSniffer

Created on 5 July 2023, over 1 year ago
Updated 21 August 2024, 3 months ago
šŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

šŸ‡®šŸ‡³India roshni27

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @roshni27
  • Merge request !3fixes issues related to phpcs ā†’ (Open) created by roshni27
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India roshni27

    please review the MR.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Status changed to Needs work 4 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @roshni27,

    I applied MR!3, it was applied smoothly and fixed most of the phpcs issues.

    These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

    āžœ  field_operations git:(8.x-2.x) curl https://git.drupalcode.org/project/field_operations/-/merge_requests/3.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  2782    0  2782    0     0   6498      0 --:--:-- --:--:-- --:--:--  6515
    patching file README.md
    patching file field_operations.libraries.yml
    patching file field_operations.links.task.yml
    patching file field_operations.routing.yml
    patching file src/Controller/FieldOperations.php
    āžœ  field_operations git:(8.x-2.x) āœ— ..
    āžœ  contrib phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js field_operations
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/field_operations/js/field_operations.js
    ------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AFFECTING 5 LINES
    ------------------------------------------------------------------------------------------------------------
     16 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
     41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
     44 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
     46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
     50 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
    ------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ------------------------------------------------------------------------------------------------------------
    
    Time: 129ms; Memory: 10MB
    
    āžœ  contrib

    Thank you.

  • Pipeline finished with Success
    4 months ago
    Total: 131s
    #260076
  • Status changed to RTBC 4 months ago
  • Pipeline finished with Success
    4 months ago
    Total: 132s
    #260093
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    avpaderno ā†’ changed the visibility of the branch 3372384-gitlab-ci-reports to hidden.

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    avpaderno ā†’ changed the visibility of the branch 3372384-fix-the-warningserrors to hidden.

  • Status changed to Needs review 4 months ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    Actually, only a PHP_CodeSniffer error is reported by GitLab CI. The existing merge request fixes PHP_CodeSniffer errors GitLab CI does not report.

  • Pipeline finished with Success
    3 months ago
    Total: 127s
    #260106
Production build 0.71.5 2024