- Issue created by @roshni27
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:08am 5 July 2023 - Status changed to Needs work
4 months ago 7:55am 21 August 2024 - šµšPhilippines cleavinjosh
Hi @roshni27,
I applied MR!3, it was applied smoothly and fixed most of the phpcs issues.
These are the remaining issues after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
:ā field_operations git:(8.x-2.x) curl https://git.drupalcode.org/project/field_operations/-/merge_requests/3.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2782 0 2782 0 0 6498 0 --:--:-- --:--:-- --:--:-- 6515 patching file README.md patching file field_operations.libraries.yml patching file field_operations.links.task.yml patching file field_operations.routing.yml patching file src/Controller/FieldOperations.php ā field_operations git:(8.x-2.x) ā .. ā contrib phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js field_operations FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/field_operations/js/field_operations.js ------------------------------------------------------------------------------------------------------------ FOUND 5 ERRORS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------ 16 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 44 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true" 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" 50 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false" ------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------ Time: 129ms; Memory: 10MB ā contrib
Thank you.
- Status changed to RTBC
4 months ago 8:26am 21 August 2024 - š®š¹Italy apaderno Brescia, š®š¹
- Merge request !5Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by apaderno
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3372384-gitlab-ci-reports to hidden.
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3372384-fix-the-warningserrors to hidden.
- Merge request !6Issue #3372384: Fix the warnings/errors reported by PHP_CodeSniffer ā (Open) created by apaderno
- Status changed to Needs review
4 months ago 8:38am 21 August 2024 - š®š¹Italy apaderno Brescia, š®š¹
Actually, only a PHP_CodeSniffer error is reported by GitLab CI. The existing merge request fixes PHP_CodeSniffer errors GitLab CI does not report.
- š®š¹Italy apaderno Brescia, š®š¹