Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

I have solved all the issues and issued an MR as above. Please review.

The status is also for the issue summary, which does not show the command and the arguments used to get the report quoted in the issue summary.

Updated.

Hi @sidharth_soman,

I applied MR!9, it was applied smoothly and fixed most of the phpcs issues.

These are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

➜  popup_message git:(2.0.2) curl https://git.drupalcode.org/project/popup_message/-/merge_requests/9.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5659    0  5659    0     0   8149      0 --:--:-- --:--:-- --:--:--  8154
patching file popup_message.module
patching file src/EventSubscriber/PopupMessageSubscriber.php
patching file src/Form/PopupMessageSettingsForm.php
patching file src/GlobalConstantsInterface.php
➜  popup_message git:(2.0.2) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig popup_message

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/popup_message/src/Form/PopupMessageSettingsForm.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 14 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/popup_message/src/EventSubscriber/PopupMessageSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Xss.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------

Time: 290ms; Memory: 12MB

➜  contrib

Moreover, MR!9 is 2 commits behind the target branch.

Thank you.

The 2.0.x branch is no longer supported.

https://git.drupalcode.org/project/popup_message/-/merge_requests/18/diffs - phpstan and phpcs fixes for the module