Add an option to only compare within the same media bundle

Yes, this is really annoying :/
I'd love to see this option.

Ok, it SHOULD theoretically already work, but there are two problems:
"$entity->id()" is NULL inside "/src/Plugin/Validation/Constraint/MediaUniqueChecksumValidator.php" "validate()". Since the entity is given down to 'checksumExists()' it is still NULL there, and we can not check its bundle (since it is NULL).

Furthermore, (and I don't get this problem at all), with the MR applied, the only enabling the restrict_duplicates setting, doesn't restrict users from creating duplicate media items anymore. This doesn't make sense to me at all... I debugged every if case and anything I added to the code everything works as expected and the old code should still work the same, but it doesn't.... Really weird, maybe some AJAX racing condition.

It also seems very odd to execute a database query through AJAX Validation? Seems very prone to issues... what are your thoughts on this @Anybody? The code should be fine like this.

Ok, I am super confused... How is "$entity->id()" NULL, but "$entity->bundle()" isn't? I couldn't debug "$entity" itself, since it is too much for the AJAX reponse. But yea using the entity->id() check instead of $entity will resolve the issue...

Ok, I see now... $media is already initialized and has its type set inside the validation, but since the media isn't submitted (aka created) yet, it doesn't have an ID!

So because 'checksumExists()' is only called once in code inside the validation, this check here:

    if ($entity->id() !== NULL) {
      $query->condition('mid', $entity->id(), '!=');
    }

is unnecessary, since '$entity->id()' is to 100% of all method calls NULL. I'll create a follow-up issue for that!

Works like a charm now! 😍

Please review!

Well done, thx! I tested with the setting active and inactive, everything works as expected.

Should @anybody review the code?

Thanks @Grevil, nice work!
I'm just not happy with the labels, don't think this is clear enough for someone using the module for the first time.

Back to NW for the wordings. Please also rename the variables accordingly once we have a clear wording. We need a native speaker ;)

Triggering @nterbogt as native speaker, perhaps he has a nice wording suggestion?

Really like "compare_within_bundle_only", maybe "compare_within_same_bundle_only"? Or a bit too long for a machine name?

@Grevil:
I think let's use

1. compare_within_same_bundle_only
2. compare_within_bundle_only
3. compare_only_within_bundle

2nd is my favorite now.
Please replace all occurrences (variables etc.) then we should be ready to go, if it was tested with and without the option.

Alright, on it.

All done, please rereview!

Oh, my apologies, there is no update hook!

Done, please review.

@thomas.frobieter could you perhaps test this? Code is fine! But should be tested manually to be sure it works as expected. You left a comment at ZMP where it would help you.

Doesn't seem to work, only one option left after switching to the issue branch, two options on the dev branch.

On branch 3372255-add-an-option
Your branch is up to date with 'origin/3372255-add-an-option'

@thomas.frobieter the new option is a dependent option, did you mark the checkbox?

Probably not, I'll try again later.

Tried all combinations, works very well, great job!

Thanks, merged!

Automatically closed - issue fixed for 2 weeks with no activity.