- Issue created by @snehal-chibde
- Issue was unassigned.
- Status changed to Needs review
12 months ago 8:27am 6 July 2023 - 🇮🇳India lokeshsahu Delhi
I have created a patch to address the above issue. I am attaching a screenshot for reference, showing the state before and after applying the patch.
- Assigned to Jay Jangid
- Issue was unassigned.
- Status changed to RTBC
12 months ago 12:34pm 6 July 2023 - 🇮🇳India Jay Jangid
Thanks @lokeshsahu, for creating the patch.
I have tested this issue with your patch.
The patch was applied successfully.
Result:-Submenus are toggling in Mobile.
See the video after-patch-applied. - 🇧🇪Belgium hansblancke
Hi, on mobile view the menus are toggled, but i get the impression that the links are not working anymore.
On normal view on pc the links are working.
Tested with drupal core 10.1.1 and tara 10.0.5
One remark, i test both views on the same device, ipad or pc, and switching from mobile to normal view the menus are not expanded, i first need to refresh the site.
Kind regards, Hans - 🇧🇪Belgium hansblancke
Hi, on mobile view the menus are toggled, but i get the impression that the links are not working anymore.
On normal view on pc the links are working.
Tested with drupal core 10.1.1 and tara 10.0.5
One remark, i test both views on the same device, ipad or pc, and switching from mobile to normal view the menus are not expanded, i first need to refresh the site.
Kind regards, Hans - Status changed to Needs work
12 months ago 5:52am 7 July 2023 - Status changed to Needs review
12 months ago 6:45am 7 July 2023 - 🇮🇳India lokeshsahu Delhi
@hansblancke Thanks for your remarks.
I have created another patch to address the issue mentioned by @hansblancke in comments #7 and #8. Now the links are also working fine on click and on click on the dropdown arrows the sub-menus are toggling.
As per comment #8, if we are switching between mobile view to normal view on the same device then we have to refresh the site to load the js for responsive view and Work properly @hansblancke.
I am attaching a video to show the updated changes for reference. - 🇧🇪Belgium hansblancke
Hi,
Thanks for the new patch, i have test it on my new site and it works.
One problem i noticed: when i go to. Administration - configuration - development and i enable the bandwidth optimization (Aggregate CSS files and Aggregate JavaScript files), clear the caches, then the links are not working anymore in the mobile view, disable it again and clear the caches, every thing is working again.
I don:’t know if this is a theme issue or a drupal issue.
Kind regards and thanks for the great job.
Hans - Status changed to Closed: works as designed
10 months ago 12:11pm 7 September 2023 - 🇮🇳India ravis
Thank you @all
Please use the patch provide above if you want to modify the default behaviour.