FIx the iissues reported by phpcs

A set of patches intended to have the same effect was submitted 6 weeks ago in:

https://www.drupal.org/project/juicebox/issues/3359798 📌 Drupal 10 patches modification to patch Needs work

However it was focused on 4.0.x. I am pretty sure that Luke and my priorities are laser focused on the 4.0.x (and going forward) versions, not on fixing the 8.x series. Reason: both Drupal 8 and 9 will be obsolete in 6 months or so. There are limited resources available and we want to make sure that there is a stable release of Juicebox for Drupal 10. Patching up the old /test directory (which is what most of the patches do) is not really gaining us anything. The recommended release 8.x-3.0-alpha2 for Drupal 8 and for Drupal 9 up to 9.3 has been out for almost 3 years. There have been no show stopper issues reported with it. It would be best if Juicebox users who intend to stay on Board could assist us in testing against Drupal 10, including Drupal 10.1 that just came out last week.

The patches in 3359798 do fix all the PHPCS issues except for the JuiceboxFormatter dependency injection issues that we are working on in issue 3371019. And the proposed patch listed in that issue seems to go a long way to fixing that.

I'm tempted to mark this issue (3371754) as closed (won't fix) but will wait to see what Luke has to say.

Furthermore, on drupal.org issues are first fixed for the most recent branch; eventually, a fix is back-ported. The back-port is done at maintainers' decision, but first the issue is fixed for the most recent branch.

Furthermore, on drupal.org issues are first fixed for the most recent branch; eventually, a fix is back-ported

Thanks @Apaderno. That is exactly what we are trying to do. As a new (and novice) maintainer I don't have all my ducks lined up in a row yet. Meanwhile we are getting suggested patches for previous releases. I am "sidelining" them for (as I think you suggested) future consideration as backports. We are trying to prioritize fixes that will relate to Drupal 10.

I have some issues that I am pretty sure relate to the file encoding of my patch files. Which. I am pretty sure, is why my initial patch doesn't apply. Am working on that now. You can see that this isssue (3371752) was created for version 8.x-3.x-dev. That's why I closed it and am trying to redirect attention to https://www.drupal.org/project/juicebox/issues/3359798 📌 Drupal 10 patches modification to patch Needs work .

When I can get the patch in 3359798 to apply and also use the suggested JuiceboxFormatter patch contributed by a community member (3371019-2.patch) I think we will be well along the way to a 4.0... stable release focused on Drupal 10. I do have a patched equivalent version of the code running locally in PHPstorm and working perfectly with Drupal 10.1. PHPCS with both Drupal related standards comes out clean as a whistle. I just need to get that working in the live Drupal.org project for Juicebox.