Drupal 10 compatibility

Hi

I reviewed the patch#2 it as still D10 issues in Unit Test file.

vendor/bin/drush upgrade_status:analyze webform_scheduled_tasks
[notice] Processing /var/www/html/vb9/web/modules/contrib/webform_scheduled_tasks-3371376.

================================================================================
Webform Scheduled Tasks, --
Scanned on Thu, 06/29/2023 - 21:57

FILE:
web/modules/contrib/webform_scheduled_tasks-3371376/src/Plugin/WebformScheduledT
asks/Task/EmailedExport.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 287 Call to deprecated function file_create_url(). Deprecated in
drupal:9.3.0 and is removed from drupal:10.0.0. Use the
appropriate method on
\Drupal\Core\File\FileUrlGeneratorInterface instead.
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/webform_scheduled_tasks-3371376/tests/src/Functional/Schedul
edTaskRunTest.php

STATUS LINE MESSAGE
--------------------------------------------------------------------------------
Check manually 68 Call to deprecated method drupalPostForm() of class
Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
is removed from drupal:10.0.0. Use $this->submitForm()
instead.
--------------------------------------------------------------------------------

Please review.

It looks like a line was accidentally left in on EmailedExportFileDownloadAccessTest. I have removed it.

New static patch uploaded.

I am not entirely sure this is correct, but it seems to have resolved the error:

https://git.drupalcode.org/project/webform_scheduled_tasks/-/merge_reque...

I keep getting this error no matter what I do:

TypeError: Drupal\webform_scheduled_tasks\Plugin\WebformScheduledTasks\Task\EmailedExport::__construct(): Argument #9 ($fileUrlGenerator) must be of type Drupal\webform_scheduled_tasks\Plugin\WebformScheduledTasks\Task\FileUrlGenerator, Drupal\Core\File\FileUrlGenerator given, called in /var/www/docroot/modules/contrib/webform_scheduled_tasks/src/Plugin/WebformScheduledTasks/Task/EmailedExport.php on line 114 in Drupal\webform_scheduled_tasks\Plugin\WebformScheduledTasks\Task\EmailedExport->__construct() (line 91 of /var/www/docroot/modules/contrib/webform_scheduled_tasks/src/Plugin/WebformScheduledTasks/Task/EmailedExport.php).

Someone who actually understands this module is probably going to have to fix this.

How goes this, my fine people? Ready to re-test in D10?

I think we have been working parallel on two issues.
#3371376 (this one)

https://www.drupal.org/project/webform_scheduled_tasks/issues/3299496 📌 Automated Drupal 10 compatibility fixes Needs review The other one
Second one mentioned above seems to have more number of changes and superset of current one.
I think we should redirect effort at one place and make it ready.

I am going to update second PR with Gitlab ci template and ensure that it passes all the test cases.

Let's close this issue in favour of the other one at https://www.drupal.org/project/webform_scheduled_tasks/issues/3299496 📌 Automated Drupal 10 compatibility fixes Needs review