- First commit to issue fork.
- Merge request !6Issue #3299496: Automated Drupal 10 compatibility fixes → (Merged) created by loopy1492
- 🇺🇸United States loopy1492
This is a duplicate of https://www.drupal.org/project/webform_scheduled_tasks/issues/3371376 📌 Drupal 10 compatibility Closed: duplicate but I've been using the branch here to figure out what was wrong with that one.
- 🇺🇸United States loopy1492
Although I've pushed what I believe are decent changes to the other thread, there are still some diffs between the two. I did this branch from scratch, I've tested it, and it seems to be working for me, so I'm going with this one. Attached please find a new static patch file.
- First commit to issue fork.
- 🇫🇷France devil2005
Hi, can you release a stable version please ?
Thanks a lot
- 🇮🇳India mohit_aghera Rajkot
Hi @devil2005
I'm already working on this.
I need to review the test case failures happening on this job https://git.drupalcode.org/project/webform_scheduled_tasks/-/jobs/211207There are phpcs issues which are fairly straight forward.
Checking the test case failures for this one. - 🇮🇳India mohit_aghera Rajkot
Hi @devil2005 @loopy1492
Can you please test the PR and let me know how it goes.I can merge the PR and cut the new release after doing initial round of testing.
All the tests and code quality checks are green. - 🇫🇷France devil2005
- 🇮🇳India mohit_aghera Rajkot
Hi @devil2005
Yeah, I've recently spinned up a 3.x branch for D10 and onwards support.
2.x branch will be kept for D8 and D9 compatibility.If you can apply this PR https://git.drupalcode.org/project/webform_scheduled_tasks/-/merge_reque... on 3.x branch.
That way you should be able to test the PR
I can merge after that.Please let me know if you need additional help.
- 🇫🇷France devil2005
Sorry but on "my server", i can't do commands... so i have to put a zip file to use modules... i know it's boring but i can't do otherwise.
If you send me an archive, i can test it todayThansk a lot
-
mohit_aghera →
committed 4b1982c8 on 3.x authored by
loopy1492 →
Issue #3299496: Automated Drupal 10 compatibility fixes
-
mohit_aghera →
committed 4b1982c8 on 3.x authored by
loopy1492 →
- 🇮🇳India mohit_aghera Rajkot
Hi @devil2005
I've created a new dev release for your testing.Feel free to download the dev release from https://ftp.drupal.org/files/projects/webform_scheduled_tasks-3.x-dev.zip and test it out.
- 🇫🇷France devil2005
Hi @mohit_aghera
Thanks a lot ! that's perfect for me, installed, tested by upgrade status and migrated on Core 10. And it's ok.
Thanks another time :)
- Status changed to RTBC
12 months ago 10:29am 30 November 2023 - 🇮🇳India mohit_aghera Rajkot
Thanks for testing @spuky
I'll create a new rc release today.
So folks can use it if they needI am planning to fix few more php8 goodies in 3.x release.
So will keep rc release until we don't make those tweaks.Meanwhile, we've already a dev release here https://www.drupal.org/project/webform_scheduled_tasks/releases/3.x-dev →
Feel free to test out in your existing projects. - Status changed to Fixed
12 months ago 2:43pm 30 November 2023 - 🇮🇳India mohit_aghera Rajkot
Thanks for the testing @spuky @devil2005
3.0.0 release candidate is available to download.https://www.drupal.org/project/webform_scheduled_tasks/releases/3.0.0-rc1 →
Automatically closed - issue fixed for 2 weeks with no activity.