Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 28 June 2023, almost 2 years ago
Updated 1 February 2024, about 1 year ago

Problem/Motivation

FILE: C:\xamppnew\htdocs\sonam\web\themes\octavia_camouflage\octavia_camouflage.theme
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AND 12 WARNINGS AFFECTING 18 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
  20 | ERROR   | [x] Doc comment short description must start with a capital letter
  55 | ERROR   | [ ] Doc comment is empty
  82 | WARNING | [ ] Hook implementations should not duplicate @param documentation
  82 | ERROR   | [ ] Missing parameter comment
  82 | ERROR   | [ ] Missing parameter type
  83 | WARNING | [ ] Hook implementations should not duplicate @param documentation
  83 | ERROR   | [ ] Missing parameter comment
  84 | WARNING | [ ] Hook implementations should not duplicate @param documentation
  84 | ERROR   | [ ] Missing parameter comment
  84 | ERROR   | [ ] Missing parameter type
 102 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 102 | ERROR   | [ ] Missing parameter comment
 102 | ERROR   | [ ] Missing parameter type
 103 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 103 | ERROR   | [ ] Missing parameter comment
 104 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 104 | ERROR   | [ ] Missing parameter comment
 104 | ERROR   | [ ] Missing parameter type
 117 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 117 | ERROR   | [ ] Missing parameter comment
 117 | ERROR   | [ ] Missing parameter type
 118 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 118 | ERROR   | [ ] Missing parameter comment
 119 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 119 | ERROR   | [ ] Missing parameter comment
 119 | ERROR   | [ ] Missing parameter type
 131 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 131 | ERROR   | [ ] Missing parameter comment
 131 | ERROR   | [ ] Missing parameter type
 132 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 132 | ERROR   | [ ] Missing parameter comment
 133 | WARNING | [ ] Hook implementations should not duplicate @param documentation
 133 | ERROR   | [ ] Missing parameter comment
 133 | ERROR   | [ ] Missing parameter type
 145 | ERROR   | [ ] Doc comment is empty
 152 | ERROR   | [ ] Doc comment is empty
 159 | ERROR   | [ ] Doc comment is empty
 179 | ERROR   | [ ] The array declaration extends to column 115 (the limit is 80). The array content should be split up over multiple lines

Steps to reproduce

Run following command
phpcs --standard=“Drupal,DrupalPractice” --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

📌 Task
Status

Needs work

Version

2.0

Component

Code

Created by

🇮🇳India sonam_sharma

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @sonam_sharma
  • Comment almost 2 years ago →
    🇮🇳India sonam_sharma
  • Comment almost 2 years ago →
    🇮🇳India sonam_sharma
  • Issue was unassigned.
  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇹Italy apaderno Brescia, 🇮🇹

    The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

  • Comment almost 2 years ago →
    🇨🇦Canada imustakim Canada

    Issue summary updated.

  • Comment about 1 year ago →
    🇮🇳India zkhan.aamir

    Hi,

    I applied patch #2 but it getting rejected.

    Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/octavia_camouflage (2.0.x)
$ curl https://www.drupal.org/files/issues/2023-06-28/3370955.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7267  100  7267    0     0  15346      0 --:--:-- --:--:-- --:--:-- 15396
patching file octavia_camouflage.theme
Hunk #5 FAILED at 78.
Hunk #6 FAILED at 97.
Hunk #7 succeeded at 136 with fuzz 2 (offset -3 lines).
Hunk #8 FAILED at 173.
3 out of 8 hunks FAILED -- saving rejects to file octavia_camouflage.theme.rej
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024